Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/ui/ash/launcher/browser_status_monitor.cc

Issue 23455037: Makes BrowserStatusMonitor remove observers in destructor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DCHECK Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/browser_status_monitor.cc
diff --git a/chrome/browser/ui/ash/launcher/browser_status_monitor.cc b/chrome/browser/ui/ash/launcher/browser_status_monitor.cc
index 738e2fbdfdbcc2d2b63aec04b752cb6f4e411466..c9965ed1b419acd26631e71fa2b4b000c4a1f1a7 100644
--- a/chrome/browser/ui/ash/launcher/browser_status_monitor.cc
+++ b/chrome/browser/ui/ash/launcher/browser_status_monitor.cc
@@ -27,10 +27,7 @@ BrowserStatusMonitor::BrowserStatusMonitor(
observed_activation_clients_(this),
observed_root_windows_(this) {
DCHECK(launcher_controller_);
- BrowserList* browser_list =
- BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_ASH);
-
- browser_list->AddObserver(this);
+ BrowserList::AddObserver(this);
// This check needs for win7_aura. Without this, all tests in
// ChromeLauncherController will fail in win7_aura.
@@ -57,10 +54,14 @@ BrowserStatusMonitor::~BrowserStatusMonitor() {
if (ash::Shell::HasInstance())
ash::Shell::GetInstance()->GetScreen()->RemoveObserver(this);
+ BrowserList::RemoveObserver(this);
+
BrowserList* browser_list =
BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_ASH);
-
- browser_list->RemoveObserver(this);
+ for (BrowserList::const_iterator i = browser_list->begin();
+ i != browser_list->end(); ++i) {
+ OnBrowserRemoved(*i);
+ }
}
void BrowserStatusMonitor::OnWindowActivated(aura::Window* gained_active,
@@ -86,6 +87,9 @@ void BrowserStatusMonitor::OnWindowDestroyed(aura::Window* window) {
}
void BrowserStatusMonitor::OnBrowserAdded(Browser* browser) {
+ if (browser->host_desktop_type() != chrome::HOST_DESKTOP_TYPE_ASH)
+ return;
+
browser->tab_strip_model()->AddObserver(this);
if (browser->is_type_popup() && browser->is_app()) {
@@ -99,6 +103,9 @@ void BrowserStatusMonitor::OnBrowserAdded(Browser* browser) {
}
void BrowserStatusMonitor::OnBrowserRemoved(Browser* browser) {
+ if (browser->host_desktop_type() != chrome::HOST_DESKTOP_TYPE_ASH)
+ return;
+
browser->tab_strip_model()->RemoveObserver(this);
if (browser_to_app_id_map_.find(browser) != browser_to_app_id_map_.end()) {
@@ -141,6 +148,9 @@ void BrowserStatusMonitor::ActiveTabChanged(content::WebContents* old_contents,
if (old_contents)
browser = chrome::FindBrowserWithWebContents(old_contents);
+ if (browser && browser->host_desktop_type() != chrome::HOST_DESKTOP_TYPE_ASH)
+ return;
+
// Update immediately on a tab change.
if (browser &&
(TabStripModel::kNoTab !=
@@ -190,6 +200,9 @@ void BrowserStatusMonitor::UpdateAppAndBrowserState(
ChromeLauncherController::APP_STATE_INACTIVE;
Browser* browser = chrome::FindBrowserWithWebContents(contents);
+ DCHECK(browser);
+ if (browser->host_desktop_type() != chrome::HOST_DESKTOP_TYPE_ASH)
+ return;
if (browser->tab_strip_model()->GetActiveWebContents() == contents) {
if (browser->window()->IsActive())
app_state = ChromeLauncherController::APP_STATE_WINDOW_ACTIVE;
« no previous file with comments | « chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698