Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 23455034: Possible fix for a Mac performance regression. (Closed)

Created:
7 years, 3 months ago by Chris Evans
Modified:
7 years, 3 months ago
Reviewers:
Tom Sepez
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez
Visibility:
Public.

Description

Possible fix for a Mac performance regression. Introduced in http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Vector.h?revision=157005 We now do the minimal amount of work possible on Vector destruction. We should now be faster than ever before: - The most common case is actually a totally unused Vector with no inline storage. In this case, we can bail and do no other work, if the buffer pointer is NULL. - There's no need to set m_size to 0 in the destructor; we've already checked that it is 0 and if not called resize(0) which will set it to 0. - In the Vector with inline storage case, we once again check m_size before calling shrink(), which might not be inline. It is common for m_size to be 0. This also saves >50KB on a GCC Release build. clang, as usual, is barely affected on account of its less aggressive inlining. BUG=283760 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M Source/wtf/Deque.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/Vector.h View 8 chunks +36 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Evans
7 years, 3 months ago (2013-09-04 01:06:13 UTC) #1
Tom Sepez
lgtm
7 years, 3 months ago (2013-09-04 01:13:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/23455034/1
7 years, 3 months ago (2013-09-04 02:49:44 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 05:13:00 UTC) #4
Message was sent while issue was closed.
Change committed as 157198

Powered by Google App Engine
This is Rietveld 408576698