Issue 23455019: Compile content_gl_tests on Android

Issue 23455019: Compile content_gl_tests on Android (Closed)

Created:
7 years, 3 months ago by no sievers

Modified:
7 years, 3 months ago

Reviewers:
cjhopman, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, craigdh+watch_chromium.org, jam, apatrick_chromium, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, piman+watch_chromium.org, klundberg+watch_chromium.org, piman, danakj+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Compile content_gl_tests on Android This adds the APK target (content_gl_tests_apk) and makes it part of the 'All' target. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221031

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : address comments #

Patch Set 5 : fix component build #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -3 lines)			Patch
	M	build/all_android.gyp	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
	M	content/content_tests.gypi	View	1 2 3 4	4 chunks	+23 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

no sievers

On 2013/08/30 17:19:44, piman wrote: > lgtm Btw the scaler and YUV readback tests fail ...

7 years, 3 months ago (2013-08-30 17:22:19 UTC) #3

cjhopman

https://codereview.chromium.org/23455019/diff/12001/build/all_android.gyp File build/all_android.gyp (right): https://codereview.chromium.org/23455019/diff/12001/build/all_android.gyp#newcode99 build/all_android.gyp:99: '../content/content.gyp:content_gl_tests_apk', nit: move this below content_browsertests_apk https://codereview.chromium.org/23455019/diff/12001/content/content_tests.gypi File content/content_tests.gypi ...

7 years, 3 months ago (2013-08-30 18:24:28 UTC) #4

no sievers

https://codereview.chromium.org/23455019/diff/12001/build/all_android.gyp File build/all_android.gyp (right): https://codereview.chromium.org/23455019/diff/12001/build/all_android.gyp#newcode99 build/all_android.gyp:99: '../content/content.gyp:content_gl_tests_apk', On 2013/08/30 18:24:28, cjhopman wrote: > nit: move ...

7 years, 3 months ago (2013-09-03 20:10:59 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/23455019/26001

7 years, 3 months ago (2013-09-03 21:30:47 UTC) #6

Message was sent while issue was closed.

Change committed as 221031

Expand Messages | Collapse Messages