Issue 23455017: Refactor how "length" parameter is obtained for HmacKeyParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23455017: Refactor how "length" parameter is obtained for HmacKeyParams. (Closed)

Created:
7 years, 3 months ago by eroman

Modified:
7 years, 3 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Refactor how the "length" parameter is obtained for HmacKeyParams. This makes it more clear to the caller that the length parameter is optional and may not be present. Being more defensive is desirable, since I saw a code review which tried to use the value without checking if it was present. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156972

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	Source/modules/crypto/HmacKeyParams.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	public/platform/WebCryptoAlgorithmParams.h	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/23455017/1

7 years, 3 months ago (2013-08-30 07:05:16 UTC) #3

Message was sent while issue was closed.

Change committed as 156972

Expand Messages | Collapse Messages