Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 23455009: Use exit command to stop web page replay server. (Closed)

Created:
7 years, 3 months ago by chrisgao (Use stgao instead)
Modified:
7 years, 3 months ago
Reviewers:
tonyg, kkania
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Use exit command to stop web page replay server. On windows, web page replay server fails to do cleanup such as restoring dns settings if it gets terminated. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220448

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Address comment and roll webpagereplay to r520. #

Total comments: 1

Patch Set 3 : Rebase. #

Total comments: 2

Patch Set 4 : Revert wpr_server.py, do it separately. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M chrome/test/functional/webpagereplay.py View 1 2 7 chunks +33 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
chrisgao (Use stgao instead)
ptal The corresponding change on web page replay is in CL https://codereview.chromium.org/23469002/
7 years, 3 months ago (2013-08-27 16:35:53 UTC) #1
tonyg
https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/core/wpr_server.py File tools/telemetry/telemetry/core/wpr_server.py (right): https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/core/wpr_server.py#newcode32 tools/telemetry/telemetry/core/wpr_server.py:32: def StopServer(self): # pylint: disable=E1002 What lint error does ...
7 years, 3 months ago (2013-08-28 01:46:34 UTC) #2
chrisgao (Use stgao instead)
ptal https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/core/wpr_server.py File tools/telemetry/telemetry/core/wpr_server.py (right): https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/core/wpr_server.py#newcode32 tools/telemetry/telemetry/core/wpr_server.py:32: def StopServer(self): # pylint: disable=E1002 On 2013/08/28 01:46:34, ...
7 years, 3 months ago (2013-08-28 04:47:44 UTC) #3
chrisgao (Use stgao instead)
https://codereview.chromium.org/23455009/diff/12001/DEPS File DEPS (right): https://codereview.chromium.org/23455009/diff/12001/DEPS#newcode236 DEPS:236: (Var("googlecode_url") % "web-page-replay") + "/trunk@520", Will revert as https://codereview.chromium.org/23628003/ ...
7 years, 3 months ago (2013-08-28 04:56:48 UTC) #4
kkania
https://codereview.chromium.org/23455009/diff/20001/chrome/test/functional/webpagereplay.py File chrome/test/functional/webpagereplay.py (right): https://codereview.chromium.org/23455009/diff/20001/chrome/test/functional/webpagereplay.py#newcode197 chrome/test/functional/webpagereplay.py:197: # Use a SIGINT so that it can do ...
7 years, 3 months ago (2013-08-29 15:30:14 UTC) #5
kkania
lgtm
7 years, 3 months ago (2013-08-29 17:54:17 UTC) #6
chrisgao (Use stgao instead)
https://codereview.chromium.org/23455009/diff/20001/chrome/test/functional/webpagereplay.py File chrome/test/functional/webpagereplay.py (right): https://codereview.chromium.org/23455009/diff/20001/chrome/test/functional/webpagereplay.py#newcode197 chrome/test/functional/webpagereplay.py:197: # Use a SIGINT so that it can do ...
7 years, 3 months ago (2013-08-29 20:54:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/23455009/25001
7 years, 3 months ago (2013-08-29 20:55:53 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 00:24:24 UTC) #9
Message was sent while issue was closed.
Change committed as 220448

Powered by Google App Engine
This is Rietveld 408576698