Encoding API: Use 'windows-1252' as name for 'us-ascii' 'iso-8859-1'

Encoding API: Use 'windows-1252' as name for 'us-ascii'  'iso-8859-1'

Aliasing is done at the API level, since Blink intentionally maintains
differently named codec instances for these, even though the same
codec is actually used.

R=kbr@chromium.org,jshin@chromium.org
BUG=277027, 277030
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156863

[jsbell, 2013-08-27 00:18:10]

I want to add a test that verifies that TextDecoder("us-ascii") and
TextDecoder("iso-8859-1") and TextDecoder("windows-1252") all decode identicaly
before landing, though.

[jsbell, 2013-08-27 00:21:04]

https://codereview.chromium.org/23455007/diff/1/Source/modules/encoding/TextD...
File Source/modules/encoding/TextDecoder.cpp (right):

https://codereview.chromium.org/23455007/diff/1/Source/modules/encoding/TextD...
Source/modules/encoding/TextDecoder.cpp:73: if (name == "iso-8859-1" || name ==
"us-ascii")
This could also be done around line 44, during the construction. That would
ensure that even if Blink diverges from having these all use the same codec
class (TextCodecLatin1) they will still all use windows-1252. On the other hand,
aliasing here means we'd actually exercise WTF's aliasing, so I'm leaning
towards keeping it here.

[Ken Russell (switch to Gerrit), 2013-08-27 03:32:54]

lgtm

https://codereview.chromium.org/23455007/diff/1/Source/modules/encoding/TextD...
File Source/modules/encoding/TextDecoder.cpp (right):

https://codereview.chromium.org/23455007/diff/1/Source/modules/encoding/TextD...
Source/modules/encoding/TextDecoder.cpp:73: if (name == "iso-8859-1" || name ==
"us-ascii")
On 2013/08/27 00:21:04, jsbell wrote:
> This could also be done around line 44, during the construction. That would
> ensure that even if Blink diverges from having these all use the same codec
> class (TextCodecLatin1) they will still all use windows-1252. On the other
hand,
> aliasing here means we'd actually exercise WTF's aliasing, so I'm leaning
> towards keeping it here.

I defer to your judgment. If the number of aliases grows large in the future, I
assume an actual data structure will be used.

[jungshik at Google, 2013-08-27 20:17:21]

LGTM !
Thanks.

[commit-bot: I haz the power, 2013-08-27 22:40:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/23455007/7001

[commit-bot: I haz the power, 2013-08-28 01:13:45]

Retried try job too often on win_blink_rel for step(s) webkit_lint,
webkit_python_tests, webkit_tests, webkit_unit_tests, weborigin_unittests,
wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-08-28 16:38:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/23455007/21001

[commit-bot: I haz the power, 2013-08-28 18:21:31]

Change committed as 156863