Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2345463004: Add browser test for vp9 subsample encrypted content (Closed)

Created:
4 years, 3 months ago by kqyang
Modified:
4 years, 2 months ago
Reviewers:
xhwang, ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add browser test for vp9 subsample encrypted content (http://www.webmproject.org/docs/webm-encryption/#46-subsample-encrypted-block-format) Bug=630344 Committed: https://crrev.com/2cf59b5b692ff2496e03baba36349c5a4f920344 Cr-Commit-Position: refs/heads/master@{#424261}

Patch Set 1 #

Patch Set 2 : new #

Total comments: 1

Patch Set 3 : Add link to spec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M media/test/data/README View 1 2 2 chunks +3 lines, -1 line 0 comments Download
D media/test/data/bear-320x240-v-vp9_enc-v.webm View Binary file 0 comments Download
A + media/test/data/bear-320x240-v-vp9_fullsample_enc-v.webm View Binary file 0 comments Download
A media/test/data/bear-320x240-v-vp9_subsample_enc-v.webm View Binary file 0 comments Download

Messages

Total messages: 22 (14 generated)
kqyang
+xhwang to review the code. Thanks.
4 years, 2 months ago (2016-10-06 19:09:52 UTC) #11
xhwang
Thanks and sorry for the delay. LGTM % nit Also, could you please provide a ...
4 years, 2 months ago (2016-10-07 19:23:43 UTC) #12
kqyang
4 years, 2 months ago (2016-10-07 20:55:43 UTC) #13
kqyang
Thanks for reviewing. On 2016/10/07 19:23:43, xhwang wrote: > Thanks and sorry for the delay. ...
4 years, 2 months ago (2016-10-07 20:57:40 UTC) #15
xhwang
lgtm
4 years, 2 months ago (2016-10-07 21:51:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345463004/40001
4 years, 2 months ago (2016-10-10 20:20:12 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-10 22:17:03 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 22:20:51 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2cf59b5b692ff2496e03baba36349c5a4f920344
Cr-Commit-Position: refs/heads/master@{#424261}

Powered by Google App Engine
This is Rietveld 408576698