Update the 'managed user import' overlay to show an avatar selection grid

chrome/browser/resources/options/managed_user_import.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
 
   /**
    * ManagedUserImportOverlay class.
    * Encapsulated handling of the 'Import existing managed user' overlay page.
    * @constructor
    * @class
    */
   function ManagedUserImportOverlay() {
-    var title = loadTimeData.getString('managedUserImportTabTitle');
+    var title = loadTimeData.getString('managedUserImportTitle');
     OptionsPage.call(this, 'managedUserImport',
                      title, 'managed-user-import');
   };
 
   cr.addSingletonGetter(ManagedUserImportOverlay);
 
   ManagedUserImportOverlay.prototype = {
     // Inherit from OptionsPage.
     __proto__: OptionsPage.prototype,
 
     /** @override */
     canShowPage: function() {
       return !BrowserOptions.getCurrentProfile().isManaged;
     },
 
     /**
      * Initialize the page.
      */
     initializePage: function() {
       // Call base class implementation to start preference initialization.
       OptionsPage.prototype.initializePage.call(this);
 
       var managedUserList = $('managed-user-list');
       options.managedUserOptions.ManagedUserList.decorate(managedUserList);
 
+      var avatarGrid = $('select-avatar-grid');
+      options.ProfilesIconGrid.decorate(avatarGrid);
+      var avatarIcons = loadTimeData.getValue('avatarIcons');
+      avatarGrid.dataModel = new ArrayDataModel(avatarIcons);
+
       managedUserList.addEventListener('change', function(event) {
         var managedUser = managedUserList.selectedItem;
         if (!managedUser)
           return;
 
         $('managed-user-import-ok').disabled =
             managedUserList.selectedItem.onCurrentDevice;
       });
 
       $('managed-user-import-cancel').onclick = function(event) {
         OptionsPage.closeOverlay();
         // 'cancelCreateProfile' is handled by BrowserOptionsHandler.
         chrome.send('cancelCreateProfile');
       };
 
-      $('managed-user-import-ok').onclick = function(event) {
-        var managedUser = managedUserList.selectedItem;
-        if (!managedUser)
-          return;
-
-        $('managed-user-import-error-bubble').hidden = true;
-        $('managed-user-import-ok').disabled = true;
-
-        // 'createProfile' is handled by BrowserOptionsHandler.
-        chrome.send('createProfile',
-            [managedUser.name, managedUser.iconURL,
-             false, true, managedUser.id]);
-      };
+      $('managed-user-import-ok').onclick =
+          this.showAvatarGridOrSubmit_.bind(this);
 
       $('create-new-user-link').onclick = function(event) {
         OptionsPage.closeOverlay();
         OptionsPage.navigateToPage('createProfile');
       };
     },
 
     /**
      * @override
      */
     didShowPage: function() {
       chrome.send('requestExistingManagedUsers');
       $('managed-user-import-error-bubble').hidden = true;
       $('managed-user-import-ok').disabled = true;
+      $('select-avatar-grid').hidden = true;
+      $('managed-user-list').hidden = false;
+
+      $('managed-user-import-ok').textContent =
+          loadTimeData.getString('managedUserImportOk');
+      $('managed-user-import-text').textContent =
+          loadTimeData.getString('managedUserImportText');
+      $('managed-user-import-title').textContent =
+          loadTimeData.getString('managedUserImportTitle');
     },
 
     /**
+     * Called when the user clicks the "OK" button. In case the managed
+     * user being imported has no avatar in sync, it shows the avatar
+     * icon grid. In case the avatar grid is visible or the managed user
+     * already has an avatar stored in sync, it proceeds with importing
+     * the managed user.
+     * @private
+     */
+    showAvatarGridOrSubmit_: function() {
+      var managedUser = $('managed-user-list').selectedItem;
+      if (!managedUser)
+        return;
+
+      $('managed-user-import-error-bubble').hidden = true;
+
+      if ($('select-avatar-grid').hidden && managedUser.needAvatar) {
+        this.showAvatarGridHelper_();
+        return;
+      }
+
+      $('managed-user-import-ok').disabled = true;
+      var avatarUrl = managedUser.needAvatar ?
+          $('select-avatar-grid').selectedItem : managedUser.iconURL;
+
+      // 'createProfile' is handled by BrowserOptionsHandler.
+      chrome.send('createProfile', [managedUser.name, avatarUrl,
+                                    false, true, managedUser.id]);
+    },
+
+    /**
+     * Hides the 'managed user list' and shows the avatar grid instead.
+     * It also updates the overlay text and title to instruct the user
+     * to choose an avatar for the supervised user.
+     * @private
+     */
+    showAvatarGridHelper_: function() {
+      $('managed-user-list').hidden = true;
+      $('select-avatar-grid').hidden = false;
+      $('select-avatar-grid').redraw();
+      $('select-avatar-grid').selectedItem =
+          loadTimeData.getValue('avatarIcons')[0];
+
+      $('managed-user-import-ok').textContent =

[Bernhard Bauer, 2013/09/13 20:33:59]

Why do you use this instead of the i18n-content attribute?

[ibra, 2013/09/13 20:52:06]

Because I display different strings on the button depending the state of the
overlay; showing managed users or avatar selection.

+          loadTimeData.getString('managedUserSelectAvatarOk');
+      $('managed-user-import-text').textContent =
+          loadTimeData.getString('managedUserSelectAvatarText');
+      $('managed-user-import-title').textContent =
+          loadTimeData.getString('managedUserSelectAvatarTitle');
+    },
+
+    /**
      * Adds all the existing |managedUsers| to the list.
      * @param {Array.<Object>} managedUsers An array of managed user objects.
      *     Each object is of the form:
      *       managedUser = {
      *         id: "Managed User ID",
      *         name: "Managed User Name",
      *         iconURL: "chrome://path/to/icon/image",
-     *         onCurrentDevice: true or false
+     *         onCurrentDevice: true or false,
+     *         needAvatar: true or false
      *       }
      * @private
      */
     receiveExistingManagedUsers_: function(managedUsers) {
       managedUsers.sort(function(a, b) {
         return a.name.localeCompare(b.name);
       });
 
       $('managed-user-list').dataModel = new ArrayDataModel(managedUsers);
       if (managedUsers.length == 0)
@@ skipping 32 matching lines @@
       var instance = ManagedUserImportOverlay.getInstance();
       return instance[name + '_'].apply(instance, arguments);
     };
   });
 
   // Export
   return {
     ManagedUserImportOverlay: ManagedUserImportOverlay,
   };
 });