Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 23454020: Update the 'managed user import' overlay to show an avatar selection grid (Closed)

Created:
7 years, 3 months ago by ibra
Modified:
7 years, 3 months ago
Reviewers:
Bernhard Bauer, Sergiu
CC:
chromium-reviews, dbeam+watch-options_chromium.org, tim+watch_chromium.org, nkostylev+watch_chromium.org, albertb+watch_chromium.org, tfarina, haitaol+watch_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, rsimha+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@show_synced_avatars_in_import_overlay
Visibility:
Public.

Description

Update the 'managed user import' overlay to show an avatar selection grid when the managed user has no avatar in sync. The selected avatar is then synced during the importing process. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223354

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : before testing #

Patch Set 4 : chromeos #

Patch Set 5 : add an avatar grid to the import overlay #

Patch Set 6 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -27 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/managed_user_import.css View 1 2 3 4 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/resources/options/managed_user_import.html View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/managed_user_import.js View 1 2 3 4 5 5 chunks +69 lines, -15 lines 2 comments Download
M chrome/browser/resources/options/managed_user_list.js View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/managed_user_import_handler.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/managed_user_import_handler.cc View 1 2 3 4 5 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ibra
Hey Sergiu, please review. Thanks!
7 years, 3 months ago (2013-09-12 08:34:31 UTC) #1
Sergiu
+Bernhard lgtm but I'd like to see some tests for this feature as well, sadly ...
7 years, 3 months ago (2013-09-13 13:11:15 UTC) #2
Sergiu
On 2013/09/13 13:11:15, Sergiu wrote: > +Bernhard > lgtm but I'd like to see some ...
7 years, 3 months ago (2013-09-13 13:12:06 UTC) #3
Bernhard Bauer
https://codereview.chromium.org/23454020/diff/24001/chrome/browser/resources/options/managed_user_import.js File chrome/browser/resources/options/managed_user_import.js (right): https://codereview.chromium.org/23454020/diff/24001/chrome/browser/resources/options/managed_user_import.js#newcode131 chrome/browser/resources/options/managed_user_import.js:131: $('managed-user-import-ok').textContent = Why do you use this instead of ...
7 years, 3 months ago (2013-09-13 20:33:59 UTC) #4
ibra
https://codereview.chromium.org/23454020/diff/24001/chrome/browser/resources/options/managed_user_import.js File chrome/browser/resources/options/managed_user_import.js (right): https://codereview.chromium.org/23454020/diff/24001/chrome/browser/resources/options/managed_user_import.js#newcode131 chrome/browser/resources/options/managed_user_import.js:131: $('managed-user-import-ok').textContent = On 2013/09/13 20:33:59, Bernhard Bauer wrote: > ...
7 years, 3 months ago (2013-09-13 20:52:06 UTC) #5
Bernhard Bauer
LGTM.
7 years, 3 months ago (2013-09-13 21:37:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@chromium.org/23454020/24001
7 years, 3 months ago (2013-09-16 13:56:00 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 17:31:29 UTC) #8
Message was sent while issue was closed.
Change committed as 223354

Powered by Google App Engine
This is Rietveld 408576698