Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: ui/gfx/canvas_mac.mm

Issue 23454018: Turn on canvas_skia for OSX (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review nits Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | ui/gfx/canvas_unittest_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/canvas_mac.mm
diff --git a/ui/gfx/canvas_mac.mm b/ui/gfx/canvas_mac.mm
deleted file mode 100644
index 247c28b6d52623e4619407263ed546e123e5f798..0000000000000000000000000000000000000000
--- a/ui/gfx/canvas_mac.mm
+++ /dev/null
@@ -1,90 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "ui/gfx/canvas.h"
-
-#import <Cocoa/Cocoa.h>
-
-#include "base/logging.h"
-#include "base/strings/sys_string_conversions.h"
-#include "third_party/skia/include/core/SkTypeface.h"
-#include "ui/gfx/font_list.h"
-#include "ui/gfx/rect.h"
-
-// Note: This is a temporary Skia-based implementation of the ui/gfx text
-// rendering routines for views/aura. It replaces the stale Cocoa-based
-// implementation. A future |canvas_skia.cc| implementation will supersede
-// this and the other platform-specific implmenentations. Most drawing options,
-// such as alignment, multi-line, and line heights are not implemented here.
-
-namespace {
-
-SkTypeface::Style FontTypefaceStyle(const gfx::Font& font) {
- int style = 0;
- if (font.GetStyle() & gfx::Font::BOLD)
- style |= SkTypeface::kBold;
- if (font.GetStyle() & gfx::Font::ITALIC)
- style |= SkTypeface::kItalic;
-
- return static_cast<SkTypeface::Style>(style);
-}
-
-} // namespace
-
-namespace gfx {
-
-// static
-void Canvas::SizeStringInt(const base::string16& text,
- const FontList& font_list,
- int* width,
- int* height,
- int line_height,
- int flags) {
- DLOG_IF(WARNING, line_height != 0) << "Line heights not implemented.";
- DLOG_IF(WARNING, flags & Canvas::MULTI_LINE) << "Multi-line not implemented.";
-
- NSFont* native_font = font_list.GetPrimaryFont().GetNativeFont();
- NSString* ns_string = base::SysUTF16ToNSString(text);
- NSDictionary* attributes =
- [NSDictionary dictionaryWithObject:native_font
- forKey:NSFontAttributeName];
- NSSize string_size = [ns_string sizeWithAttributes:attributes];
- *width = string_size.width;
- *height = font_list.GetHeight();
-}
-
-void Canvas::DrawStringRectWithShadows(const base::string16& text,
- const FontList& font_list,
- SkColor color,
- const Rect& text_bounds,
- int line_height,
- int flags,
- const ShadowValues& shadows) {
- DLOG_IF(WARNING, line_height != 0) << "Line heights not implemented.";
- DLOG_IF(WARNING, flags & Canvas::MULTI_LINE) << "Multi-line not implemented.";
- DLOG_IF(WARNING, !shadows.empty()) << "Text shadows not implemented.";
-
- const Font& font = font_list.GetPrimaryFont();
- skia::RefPtr<SkTypeface> typeface = skia::AdoptRef(
- SkTypeface::CreateFromName(
- font.GetFontName().c_str(), FontTypefaceStyle(font)));
- SkPaint paint;
- paint.setTypeface(typeface.get());
- paint.setColor(color);
- canvas_->drawText(text.c_str(),
- text.size() * sizeof(base::string16::value_type),
- text_bounds.x(),
- text_bounds.bottom(),
- paint);
-}
-
-void Canvas::DrawStringRectWithHalo(const base::string16& text,
- const FontList& font_list,
- SkColor text_color,
- SkColor halo_color,
- const Rect& display_rect,
- int flags) {
-}
-
-} // namespace gfx
« no previous file with comments | « build/common.gypi ('k') | ui/gfx/canvas_unittest_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698