Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Side by Side Diff: ui/gfx/canvas_unittest_mac.mm

Issue 23454018: Turn on canvas_skia for OSX (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review nits Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/gfx/canvas_mac.mm ('k') | ui/ui.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "ui/gfx/canvas.h"
6
7 #import <Cocoa/Cocoa.h>
8
9 #include "base/strings/utf_string_conversions.h"
10 #include "base/strings/sys_string_conversions.h"
11 #include "testing/gtest/include/gtest/gtest.h"
12 #include "ui/gfx/font.h"
13 #include "ui/gfx/font_list.h"
14
15 namespace gfx {
16
17 namespace {
18
19 // Mac-specific code for string size computations. This is a verbatim copy
20 // of the old implementation that used to be in canvas_mac.mm.
21 void CanvasMac_SizeStringInt(const base::string16& text,
22 const FontList& font_list,
23 int* width,
24 int* height,
25 int line_height,
26 int flags) {
27 DLOG_IF(WARNING, line_height != 0) << "Line heights not implemented.";
28 DLOG_IF(WARNING, flags & Canvas::MULTI_LINE) << "Multi-line not implemented.";
29
30 NSFont* native_font = font_list.GetPrimaryFont().GetNativeFont();
31 NSString* ns_string = base::SysUTF16ToNSString(text);
32 NSDictionary* attributes =
33 [NSDictionary dictionaryWithObject:native_font
34 forKey:NSFontAttributeName];
35 NSSize string_size = [ns_string sizeWithAttributes:attributes];
36 *width = string_size.width;
37 *height = font_list.GetHeight();
38 }
39
40 } // namespace
41
42 class CanvasTestMac : public testing::Test {
43 protected:
44 // Compare the size returned by Canvas::SizeStringInt to the size generated
45 // by the platform-specific version in CanvasMac_SizeStringInt. Will generate
46 // expectation failure on any mismatch. Only works for single-line text
47 // without specified line height, since that is all the platform
48 // implementation supports.
49 void CompareSizes(const char* text) {
50 FontList font_list(font_);
51 base::string16 text16 = base::UTF8ToUTF16(text);
52
53 int mac_width = -1;
54 int mac_height = -1;
55 CanvasMac_SizeStringInt(text16, font_list, &mac_width, &mac_height, 0, 0);
56
57 int canvas_width = -1;
58 int canvas_height = -1;
59 Canvas::SizeStringInt(
60 text16, font_list, &canvas_width, &canvas_height, 0, 0);
61
62 EXPECT_EQ(mac_width, canvas_width) << " width for " << text;
63 EXPECT_EQ(mac_height, canvas_height) << " height for " << text;
64 }
65
66 private:
67 Font font_;
68 };
69
70 // Tests that Canvas' SizeStringInt yields result consistent with a native
71 // implementation.
72 TEST_F(CanvasTestMac, StringSizeIdenticalForSkia) {
73 CompareSizes("");
74 CompareSizes("Foo");
75 CompareSizes("Longword");
76 CompareSizes("This is a complete sentence.");
77 }
78
79 } // namespace gfx
OLDNEW
« no previous file with comments | « ui/gfx/canvas_mac.mm ('k') | ui/ui.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698