Issue 23454018: Turn on canvas_skia for OSX

Issue 23454018: Turn on canvas_skia for OSX (Closed)

Created:
7 years, 3 months ago by groby-ooo-7-16

Modified:
7 years, 3 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Turn on canvas_skia for OSX Re-submit of r221930, with fixed include path. TBR=asvitkine@chromium.org BUG=151935 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222192

Patch Set 2 : Address review nits. #

Patch Set 3 : Address review nits #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -93 lines)			Patch
M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
D	ui/gfx/canvas_mac.mm	View		1 chunk	+0 lines, -90 lines	0 comments	Download
A	ui/gfx/canvas_unittest_mac.mm	View	1	1 chunk	+79 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	ui/ui_unittests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

asvitkine: Can I have a quick glance over this? (Only changed include path)

7 years, 3 months ago (2013-09-09 20:03:20 UTC) #1

Alexei Svitkine (slow)

LGTM with a comment https://codereview.chromium.org/23454018/diff/1/ui/gfx/canvas_unittest_mac.mm File ui/gfx/canvas_unittest_mac.mm (right): https://codereview.chromium.org/23454018/diff/1/ui/gfx/canvas_unittest_mac.mm#newcode14 ui/gfx/canvas_unittest_mac.mm:14: #include "ui/gfx/range/range.h" Does this actually ...

7 years, 3 months ago (2013-09-09 20:07:37 UTC) #2

Alexei Svitkine (slow)

(still LGTM) Also, a nit: https://codereview.chromium.org/23454018/diff/1/ui/gfx/canvas_unittest_mac.mm File ui/gfx/canvas_unittest_mac.mm (right): https://codereview.chromium.org/23454018/diff/1/ui/gfx/canvas_unittest_mac.mm#newcode23 ui/gfx/canvas_unittest_mac.mm:23: const gfx::FontList& font_list, Nit: ...

7 years, 3 months ago (2013-09-09 20:09:08 UTC) #3

groby-ooo-7-16

https://codereview.chromium.org/23454018/diff/1/ui/gfx/canvas_unittest_mac.mm File ui/gfx/canvas_unittest_mac.mm (right): https://codereview.chromium.org/23454018/diff/1/ui/gfx/canvas_unittest_mac.mm#newcode14 ui/gfx/canvas_unittest_mac.mm:14: #include "ui/gfx/range/range.h" On 2013/09/09 20:07:38, Alexei Svitkine wrote: > ...

7 years, 3 months ago (2013-09-09 20:23:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/23454018/8001

7 years, 3 months ago (2013-09-09 20:23:54 UTC) #5

Message was sent while issue was closed.

Change committed as 222192

Expand Messages | Collapse Messages