tools/metrics/histograms/histograms.xml - Issue 23453032: Chrome.BrowserCrashDumpAttempts needs to account for multiple dumps from the same browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 23453032: Chrome.BrowserCrashDumpAttempts needs to account for multiple dumps from the same browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Retry git cl upload Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 84b6c97cfe2851fc4f92fa5de7f07b121d9d5362..862acddf214ef8c7ebfbe8fa6e3b1de9a2f7001f 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -1223,7 +1223,23 @@ other types of suffix sets.

- Number of time the browser processes attempts to generate a crash dump.

+ The total number of times the browser process has attempted to generate a

+ crash dump. This should be the sum of Chrome.BrowserDumpsWithCrash and

+ Chrome.BrowserDumpsWithNoCrash.

+ </summary>

+</histogram>

+<histogram name="Chrome.BrowserDumpsWithCrash">

+ <summary>

+ The number of times the browser process has attempted to generate a crash

+ dump because of an actual browser crash.

+ </summary>

+</histogram>

+<histogram name="Chrome.BrowserDumpsWithNoCrash">

+ <summary>

+ The number of times the browser process has attempted to generate a crash

+ dump in a non-crashing (i.e., reporting only) context.

</summary>

</histogram>

« no previous file with comments | « chrome/browser/metrics/metrics_service.cc ('k') | no next file » | no next file with comments »