Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: media/audio/audio_manager_base.cc

Issue 23453022: Add AudioManager::GetAudioOutputDeviceNames and implement for pulseaudio. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mediaCleanups
Patch Set: Add missing override. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/audio/audio_manager_base.h ('k') | media/audio/audio_manager_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/audio/audio_manager_base.h" 5 #include "media/audio/audio_manager_base.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/message_loop/message_loop_proxy.h" 10 #include "base/message_loop/message_loop_proxy.h"
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 dispatcher_params->dispatcher = dispatcher; 302 dispatcher_params->dispatcher = dispatcher;
303 output_dispatchers_.push_back(dispatcher_params); 303 output_dispatchers_.push_back(dispatcher_params);
304 return new AudioOutputProxy(dispatcher.get()); 304 return new AudioOutputProxy(dispatcher.get());
305 #endif // defined(OS_IOS) 305 #endif // defined(OS_IOS)
306 } 306 }
307 307
308 void AudioManagerBase::ShowAudioInputSettings() { 308 void AudioManagerBase::ShowAudioInputSettings() {
309 } 309 }
310 310
311 void AudioManagerBase::GetAudioInputDeviceNames( 311 void AudioManagerBase::GetAudioInputDeviceNames(
312 media::AudioDeviceNames* device_names) { 312 AudioDeviceNames* device_names) {
313 }
314
315 void AudioManagerBase::GetAudioOutputDeviceNames(
316 AudioDeviceNames* device_names) {
317 // TODO(joi): Remove this and keep pure virtual once implemented everywhere.
318 NOTIMPLEMENTED();
313 } 319 }
314 320
315 void AudioManagerBase::ReleaseOutputStream(AudioOutputStream* stream) { 321 void AudioManagerBase::ReleaseOutputStream(AudioOutputStream* stream) {
316 DCHECK(stream); 322 DCHECK(stream);
317 // TODO(xians) : Have a clearer destruction path for the AudioOutputStream. 323 // TODO(xians) : Have a clearer destruction path for the AudioOutputStream.
318 // For example, pass the ownership to AudioManager so it can delete the 324 // For example, pass the ownership to AudioManager so it can delete the
319 // streams. 325 // streams.
320 --num_output_streams_; 326 --num_output_streams_;
321 delete stream; 327 delete stream;
322 } 328 }
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
420 NOTIMPLEMENTED(); 426 NOTIMPLEMENTED();
421 return ""; 427 return "";
422 } 428 }
423 429
424 std::string AudioManagerBase::GetDefaultOutputDeviceID() { 430 std::string AudioManagerBase::GetDefaultOutputDeviceID() {
425 NOTIMPLEMENTED(); 431 NOTIMPLEMENTED();
426 return ""; 432 return "";
427 } 433 }
428 434
429 } // namespace media 435 } // namespace media
OLDNEW
« no previous file with comments | « media/audio/audio_manager_base.h ('k') | media/audio/audio_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698