Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 23452031: Add reference to -webkit-app-region CSS style for no-frame windows. (Closed)

Created:
7 years, 3 months ago by Greg Billock
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, scheib+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add reference to -webkit-app-region CSS style for no-frame windows. R=asargent@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223436

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Add a bit more explanation #

Total comments: 2

Patch Set 4 : code tag #

Total comments: 2

Patch Set 5 : More code tag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/common/extensions/api/app_window.idl View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Greg Billock
7 years, 3 months ago (2013-09-13 22:40:56 UTC) #1
scheib
lgtm with additional usage text. https://codereview.chromium.org/23452031/diff/5001/chrome/common/extensions/api/app_window.idl File chrome/common/extensions/api/app_window.idl (right): https://codereview.chromium.org/23452031/diff/5001/chrome/common/extensions/api/app_window.idl#newcode73 chrome/common/extensions/api/app_window.idl:73: // the -webkit-app-region CSS ...
7 years, 3 months ago (2013-09-15 04:35:15 UTC) #2
Greg Billock
https://codereview.chromium.org/23452031/diff/5001/chrome/common/extensions/api/app_window.idl File chrome/common/extensions/api/app_window.idl (right): https://codereview.chromium.org/23452031/diff/5001/chrome/common/extensions/api/app_window.idl#newcode73 chrome/common/extensions/api/app_window.idl:73: // the -webkit-app-region CSS property can be used to ...
7 years, 3 months ago (2013-09-16 17:47:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/23452031/9001
7 years, 3 months ago (2013-09-16 17:47:50 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=25672
7 years, 3 months ago (2013-09-16 18:03:37 UTC) #5
Greg Billock
On 2013/09/16 18:03:37, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 3 months ago (2013-09-16 18:07:54 UTC) #6
not at google - send to devlin
https://codereview.chromium.org/23452031/diff/9001/chrome/common/extensions/api/app_window.idl File chrome/common/extensions/api/app_window.idl (right): https://codereview.chromium.org/23452031/diff/9001/chrome/common/extensions/api/app_window.idl#newcode75 chrome/common/extensions/api/app_window.idl:75: // regions draggable. "no-drag" can be used to disable ...
7 years, 3 months ago (2013-09-16 18:18:41 UTC) #7
Greg Billock
https://codereview.chromium.org/23452031/diff/9001/chrome/common/extensions/api/app_window.idl File chrome/common/extensions/api/app_window.idl (right): https://codereview.chromium.org/23452031/diff/9001/chrome/common/extensions/api/app_window.idl#newcode75 chrome/common/extensions/api/app_window.idl:75: // regions draggable. "no-drag" can be used to disable ...
7 years, 3 months ago (2013-09-16 18:21:58 UTC) #8
not at google - send to devlin
lgtm https://codereview.chromium.org/23452031/diff/21001/chrome/common/extensions/api/app_window.idl File chrome/common/extensions/api/app_window.idl (right): https://codereview.chromium.org/23452031/diff/21001/chrome/common/extensions/api/app_window.idl#newcode73 chrome/common/extensions/api/app_window.idl:73: // the -webkit-app-region CSS property can be used ...
7 years, 3 months ago (2013-09-16 18:25:40 UTC) #9
Greg Billock
https://codereview.chromium.org/23452031/diff/21001/chrome/common/extensions/api/app_window.idl File chrome/common/extensions/api/app_window.idl (right): https://codereview.chromium.org/23452031/diff/21001/chrome/common/extensions/api/app_window.idl#newcode73 chrome/common/extensions/api/app_window.idl:73: // the -webkit-app-region CSS property can be used to ...
7 years, 3 months ago (2013-09-16 18:49:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/23452031/19001
7 years, 3 months ago (2013-09-16 18:54:21 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 22:02:52 UTC) #12
Message was sent while issue was closed.
Change committed as 223436

Powered by Google App Engine
This is Rietveld 408576698