Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 23451015: Add a new histogram: Net.QuicSession.OutOfOrderGapReceived (Closed)

Created:
7 years, 3 months ago by Ryan Hamilton
Modified:
7 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Add a new histogram: Net.QuicSession.OutOfOrderGapReceived The number of missing packets between the current received packet and the previously largest received packet sequence number, when the current received packet had a lower sequence number than the previously received packet sequence number. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221955

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M net/quic/quic_connection_logger.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Hamilton
7 years, 3 months ago (2013-09-07 13:52:45 UTC) #1
jar (doing other things)
lgtm This metric will me interesting to understand, especially as we fix the code that ...
7 years, 3 months ago (2013-09-08 14:41:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/23451015/1
7 years, 3 months ago (2013-09-08 14:41:29 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-08 15:02:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/23451015/30001
7 years, 3 months ago (2013-09-08 15:42:01 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-08 23:34:02 UTC) #6
Message was sent while issue was closed.
Change committed as 221955

Powered by Google App Engine
This is Rietveld 408576698