Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23450041: Set default audio constraints for mediastreams with audio. (Closed)

Created:
7 years, 3 months ago by tommi (sloooow) - chröme
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Set default audio constraints for mediastreams with audio. BUG=289396 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223605

Patch Set 1 #

Patch Set 2 : Apply the default settings to the source #

Patch Set 3 : Remove check for '2' constraints. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -16 lines) Patch
M content/renderer/media/media_stream_dependency_factory.cc View 1 2 3 chunks +25 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tommi (sloooow) - chröme
Apply the default settings to the source
7 years, 3 months ago (2013-09-16 20:51:22 UTC) #1
tommi (sloooow) - chröme
7 years, 3 months ago (2013-09-16 20:52:23 UTC) #2
tommi (sloooow) - chröme
Remove check for '2' constraints.
7 years, 3 months ago (2013-09-17 05:58:21 UTC) #3
no longer working on chromium
On 2013/09/17 05:58:21, tommi wrote: > Remove check for '2' constraints. lgtm
7 years, 3 months ago (2013-09-17 09:16:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/23450041/21001
7 years, 3 months ago (2013-09-17 09:17:51 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 13:47:25 UTC) #6
Message was sent while issue was closed. 
Change committed as 223605

Powered by Google App Engine
This is Rietveld 408576698