Issue 23449036: importer: Allow user to import some missing URLS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23449036: importer: Allow user to import some missing URLS. (Closed)

Created:
7 years, 3 months ago by tfarina

Modified:
7 years, 3 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

importer: Allow user to import some missing URLS. More specifically, we were not allowing the user to import chrome://chrome and chrome://about. We add the necessary checks and now the user can import those urls too. BUG=283715 TEST=launch chrome, go to bookmarks manager, select "Import Bookmarks from HTML file", choose an html file that contains either chrome://chrome or chrome://about or both, verify that now we can import those. R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223432

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/utility/importer/bookmarks_file_importer.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/utility/importer/bookmarks_file_importer_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23449036/1

7 years, 3 months ago (2013-09-16 18:03:52 UTC) #3

Message was sent while issue was closed.

Change committed as 223432

Expand Messages | Collapse Messages