Issue 23449027: Stop sending long press events twice

Issue 23449027: Stop sending long press events twice (Closed)

Created:
7 years, 3 months ago by Kristian Monsen

Modified:
7 years, 3 months ago

Reviewers:
joth, benm (inactive), boliu

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Stop sending long press events twice Removing one of the events. BUG=285999 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221881

Patch Set 2 : Removed moar code #

Patch Set 4 : Removed header include #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -28 lines)			Patch
M	android_webview/java/src/org/chromium/android_webview/AwContents.java	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	android_webview/native/aw_contents.h	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	android_webview/native/aw_contents.cc	View	1 2	1 chunk	+0 lines, -9 lines	0 comments	Download
M	android_webview/native/aw_web_contents_view_delegate.cc	View	1 2 3	2 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

boliu

lgtm https://codereview.chromium.org/23449027/diff/7001/android_webview/native/aw_web_contents_view_delegate.cc File android_webview/native/aw_web_contents_view_delegate.cc (right): https://codereview.chromium.org/23449027/diff/7001/android_webview/native/aw_web_contents_view_delegate.cc#newcode7 android_webview/native/aw_web_contents_view_delegate.cc:7: #include "android_webview/native/aw_contents.h" Can delete this include as well ...

7 years, 3 months ago (2013-09-05 22:25:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kristianm@chromium.org/23449027/12001

7 years, 3 months ago (2013-09-06 22:03:00 UTC) #5

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 3 months ago (2013-09-07 00:29:38 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kristianm@chromium.org/23449027/12001

7 years, 3 months ago (2013-09-07 00:36:04 UTC) #7

Message was sent while issue was closed.

Change committed as 221881

Expand Messages | Collapse Messages