iTunes artist, album, and track names need to be escaped for slash and colon.

iTunes artist, album, and track names need to be escaped for slash and colon.

Slash is an invalid path character.  Colon isn't used on Mac.  In both cases, an underscore is subsisted.

BUG=281701
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220681

[Lei Zhang, 2013-08-29 23:28:38]

lgtm

https://codereview.chromium.org/23449015/diff/1/chrome/browser/media_gallerie...
File chrome/browser/media_galleries/fileapi/itunes_data_provider.cc (right):

https://codereview.chromium.org/23449015/diff/1/chrome/browser/media_gallerie...
chrome/browser/media_galleries/fileapi/itunes_data_provider.cc:73:
EscapeBadCharacters((*track_it)->location
Can we use more temp vars so this is easier to read?

https://codereview.chromium.org/23449015/diff/1/chrome/browser/media_gallerie...
File chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc
(right):

https://codereview.chromium.org/23449015/diff/1/chrome/browser/media_gallerie...
chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc:404:
entries.push_back(LibraryEntry("Artist:/name", "Album:name/", track));
Can we add either some more entries or another test, to test escaping + unique
names?

[vandebo (ex-Chrome), 2013-08-30 03:48:32]

https://codereview.chromium.org/23449015/diff/1/chrome/browser/media_gallerie...
File chrome/browser/media_galleries/fileapi/itunes_data_provider.cc (right):

https://codereview.chromium.org/23449015/diff/1/chrome/browser/media_gallerie...
chrome/browser/media_galleries/fileapi/itunes_data_provider.cc:73:
EscapeBadCharacters((*track_it)->location
On 2013/08/29 23:28:38, Lei Zhang wrote:
> Can we use more temp vars so this is easier to read?

Done.

https://codereview.chromium.org/23449015/diff/1/chrome/browser/media_gallerie...
File chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc
(right):

https://codereview.chromium.org/23449015/diff/1/chrome/browser/media_gallerie...
chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc:404:
entries.push_back(LibraryEntry("Artist:/name", "Album:name/", track));
On 2013/08/29 23:28:38, Lei Zhang wrote:
> Can we add either some more entries or another test, to test escaping + unique
> names?

Done.

[commit-bot: I haz the power, 2013-08-30 03:48:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/23449015/11001

[commit-bot: I haz the power, 2013-08-30 06:19:08]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-08-30 15:34:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/23449015/11001

[commit-bot: I haz the power, 2013-08-30 17:52:47]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-08-30 20:27:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/23449015/47001

[commit-bot: I haz the power, 2013-08-30 22:35:20]

Change committed as 220681