Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 23449012: Close the shared audio output device when the tab is closed. (Closed)

Created:
7 years, 3 months ago by tommi (sloooow) - chröme
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Close the shared audio output device when the tab is closed. The audio device is currently shared between multiple media players, but we were missing a step that frees the device when the tab is closed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/renderer/media/media_stream_impl.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommi (sloooow) - chröme
7 years, 3 months ago (2013-08-29 14:53:41 UTC) #1
no longer working on chromium
On 2013/08/29 14:53:41, tommi wrote: lgtm
7 years, 3 months ago (2013-08-29 15:34:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/23449012/1
7 years, 3 months ago (2013-08-29 16:46:20 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 21:04:12 UTC) #4
Message was sent while issue was closed.
Change committed as 220364

Powered by Google App Engine
This is Rietveld 408576698