Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 23449011: Move the directory of CLD2 (Closed)

Created:
7 years, 3 months ago by hajimehoshi
Modified:
7 years, 3 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, Takashi Toyoshima, cpu_(ooo_6.6-7.5), M-A Ruel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move the directory of CLD2 To put the file README.chromium, OWNERS and so on, we need to move the directory of the third-party library. We cannot assure that it is safe to move from 'third_party/cld2' to 'third_party/cld2/src', so we adopted the new path 'third_party/cld_2'. See: https://codereview.chromium.org/23301019/ Note: the newer revision (r74) of CLD2 is specified because the newer version includes some security fixes. BUG=240647 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220832

Patch Set 1 #

Patch Set 2 : (Rebasing) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hajimehoshi
Can you take a look? Thank you in advance. I posted at chromium-dev about how ...
7 years, 3 months ago (2013-08-29 07:10:55 UTC) #1
Isaac (away)
lgtm. Please make you to also add this to svnignore (see instructions for new third_party ...
7 years, 3 months ago (2013-08-29 21:26:22 UTC) #2
hajimehoshi
On 2013/08/29 21:26:22, Isaac wrote: > lgtm. Please make you to also add this to ...
7 years, 3 months ago (2013-08-30 02:30:59 UTC) #3
hajimehoshi
On 2013/08/30 02:30:59, hajimehoshi wrote: > On 2013/08/29 21:26:22, Isaac wrote: > > lgtm. Please ...
7 years, 3 months ago (2013-09-02 06:46:58 UTC) #4
Isaac (away)
Create cld_2 in chromium svn, set svnignore on the src folder and then add the ...
7 years, 3 months ago (2013-09-02 08:25:38 UTC) #5
hajimehoshi
On 2013/09/02 08:25:38, Isaac wrote: > Create cld_2 in chromium svn, set svnignore on the ...
7 years, 3 months ago (2013-09-02 08:42:54 UTC) #6
hajimehoshi
On 2013/09/02 08:42:54, hajimehoshi wrote: > On 2013/09/02 08:25:38, Isaac wrote: > > Create cld_2 ...
7 years, 3 months ago (2013-09-02 09:25:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/23449011/13001
7 years, 3 months ago (2013-09-02 09:31:10 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-02 11:53:01 UTC) #9
Message was sent while issue was closed.
Change committed as 220832

Powered by Google App Engine
This is Rietveld 408576698