Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 23447013: Updated cloud devices page to have more general UI (Closed)

Created:
7 years, 3 months ago by Noam Samuel
Modified:
7 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Updated cloud devices page to have more general UI - Printers now have printer icon next to them - Text before the registration step refers to "devices" rather than "printers" BUG=286157 TBR=thestig Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.css View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Noam Samuel
7 years, 3 months ago (2013-09-06 01:22:37 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 3 months ago (2013-09-06 01:28:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23447013/1
7 years, 3 months ago (2013-09-06 01:29:07 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/app/generated_resources.grd: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-06 01:29:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23447013/1
7 years, 3 months ago (2013-09-07 04:53:06 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=24305
7 years, 3 months ago (2013-09-07 05:03:49 UTC) #6
Vitaly Buka (NO REVIEWS)
+thestig for chrome/browser/browser_resources.grd
7 years, 3 months ago (2013-09-07 05:09:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23447013/1
7 years, 3 months ago (2013-09-07 05:09:36 UTC) #8
commit-bot: I haz the power
Change committed as 221921
7 years, 3 months ago (2013-09-07 15:48:13 UTC) #9
Lei Zhang
7 years, 3 months ago (2013-09-07 23:47:45 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698