Add interface for DesktopMediaPickerModel

Add interface for DesktopMediaPickerModel

This CL adds an interface for DesktopMediaPickerModel
(DesktopMediaPickerModelInterface). It allows the model to be
faked/mocked/stubbed in unittests.

BUG=237907
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221795

[Sergey Ulanov, 2013-09-04 20:39:00]

https://codereview.chromium.org/23447012/diff/5001/chrome/browser/media/deskt...
File chrome/browser/media/desktop_media_picker_model.h (right):

https://codereview.chromium.org/23447012/diff/5001/chrome/browser/media/deskt...
chrome/browser/media/desktop_media_picker_model.h:24: class
DesktopMediaPickerModelInterface {
We don't normally use "Interface" suffix in chromium. Instead it's better to
keep the old name for the interface and then call the implementation
DesktopMediaPickerModelImpl.

[dcaiafa, 2013-09-04 22:41:37]

PTAL

https://codereview.chromium.org/23447012/diff/5001/chrome/browser/media/deskt...
File chrome/browser/media/desktop_media_picker_model.h (right):

https://codereview.chromium.org/23447012/diff/5001/chrome/browser/media/deskt...
chrome/browser/media/desktop_media_picker_model.h:24: class
DesktopMediaPickerModelInterface {
On 2013/09/04 20:39:00, Sergey Ulanov wrote:
> We don't normally use "Interface" suffix in chromium. Instead it's better to
> keep the old name for the interface and then call the implementation
> DesktopMediaPickerModelImpl.

Done.

[Sergey Ulanov, 2013-09-04 22:50:05]

lgtm

https://codereview.chromium.org/23447012/diff/13001/chrome/browser/media/desk...
File chrome/browser/media/desktop_media_picker_model.h (right):

https://codereview.chromium.org/23447012/diff/13001/chrome/browser/media/desk...
chrome/browser/media/desktop_media_picker_model.h:75:
DISALLOW_ASSIGN(DesktopMediaPickerModel);
nit: Why not DISALLOW_COPY_AND_ASSIGN? In either case it's not really useful for
abstract interfaces, so you can just remove this line.

[dcaiafa, 2013-09-04 23:00:27]

Thanks.

https://codereview.chromium.org/23447012/diff/13001/chrome/browser/media/desk...
File chrome/browser/media/desktop_media_picker_model.h (right):

https://codereview.chromium.org/23447012/diff/13001/chrome/browser/media/desk...
chrome/browser/media/desktop_media_picker_model.h:75:
DISALLOW_ASSIGN(DesktopMediaPickerModel);
On 2013/09/04 22:50:06, Sergey Ulanov wrote:
> nit: Why not DISALLOW_COPY_AND_ASSIGN? In either case it's not really useful
for
> abstract interfaces, so you can just remove this line.

Done.

[commit-bot: I haz the power, 2013-09-04 23:02:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcaiafa@chromium.org/23447012/18001

[commit-bot: I haz the power, 2013-09-04 23:27:33]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-04 23:33:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcaiafa@chromium.org/23447012/18001

[commit-bot: I haz the power, 2013-09-04 23:42:54]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_dbg_simulator.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-06 18:34:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcaiafa@chromium.org/23447012/18001

[commit-bot: I haz the power, 2013-09-06 22:21:01]

Change committed as 221795