Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23445020: Support inputmode attribute for Windows Aura. (Closed)

Created:
7 years, 3 months ago by yoichio
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Support inputmode attribute for Windows Aura. BUG=244688 TEST=Windows7 with MS-IME and GoogleJapaneseInput. Windows8 desktop using onscreen keyboard with MS-IME and GoogleJapaneseInput. The known issue about onscreenkeyboard and MS-IME still happens. https://src.chromium.org/viewvc/chrome?revision=220221&view=revision Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221588

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove unused include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 3 chunks +4 lines, -1 line 0 comments Download
M ui/base/ime/input_method_imm32.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
yoichio
Could you review?
7 years, 3 months ago (2013-08-30 08:29:48 UTC) #1
yoichio
I don't know which yukawa is true Yukawa-san. but add Yukawa@. And ping?
7 years, 3 months ago (2013-09-02 04:06:09 UTC) #2
Yohei Yukawa
https://codereview.chromium.org/23445020/diff/1/ui/base/ime/input_method_imm32.cc File ui/base/ime/input_method_imm32.cc (right): https://codereview.chromium.org/23445020/diff/1/ui/base/ime/input_method_imm32.cc#newcode10 ui/base/ime/input_method_imm32.cc:10: #include "ui/base/ime/win/tsf_input_scope.h" Do we really need this header?
7 years, 3 months ago (2013-09-02 04:20:07 UTC) #3
yoichio
https://codereview.chromium.org/23445020/diff/1/ui/base/ime/input_method_imm32.cc File ui/base/ime/input_method_imm32.cc (right): https://codereview.chromium.org/23445020/diff/1/ui/base/ime/input_method_imm32.cc#newcode10 ui/base/ime/input_method_imm32.cc:10: #include "ui/base/ime/win/tsf_input_scope.h" On 2013/09/02 04:20:07, Yohei Yukawa wrote: > ...
7 years, 3 months ago (2013-09-02 04:56:58 UTC) #4
Yohei Yukawa
lgtm
7 years, 3 months ago (2013-09-02 04:58:44 UTC) #5
yoichio
Add sky@ as OWNER. Could you watch this?
7 years, 3 months ago (2013-09-02 05:00:26 UTC) #6
sky
LGTM
7 years, 3 months ago (2013-09-03 16:09:05 UTC) #7
yoichio
ping nona@
7 years, 3 months ago (2013-09-06 00:48:52 UTC) #8
Seigo Nonaka
lgtm Sorry for late response.
7 years, 3 months ago (2013-09-06 01:05:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/23445020/9001
7 years, 3 months ago (2013-09-06 01:06:43 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 05:48:47 UTC) #11
Message was sent while issue was closed. 
Change committed as 221588

Powered by Google App Engine
This is Rietveld 408576698