Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 23444061: Test that LoginState observer triggers when only user type changes (Closed)

Created:
7 years, 3 months ago by tbarzic
Modified:
7 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Test that LoginState observer triggers when only user type changes Also, remove some uneeded dependencies from LoginState tests. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223468

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : a spelling error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M chromeos/login/login_state_unittest.cc View 1 2 7 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tbarzic
Almost accidentally regressed this with the last patch, so here's a test :)
7 years, 3 months ago (2013-09-16 18:54:15 UTC) #1
stevenjb
Thanks for adding, lgtm
7 years, 3 months ago (2013-09-16 20:04:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/23444061/7001
7 years, 3 months ago (2013-09-16 20:13:03 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 23:30:26 UTC) #4
Message was sent while issue was closed.
Change committed as 223468

Powered by Google App Engine
This is Rietveld 408576698