Source/core/inspector/InspectorPageAgent.cpp - Issue 23444058: Use downloadToFile option when XHR downloads a Blob

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorPageAgent.cpp

Issue 23444058: Use downloadToFile option when XHR downloads a Blob (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/inspector/timeline-xhr-response-type-blob-event.html ('K') | « Source/core/fetch/ResourceLoaderHost.h ('k') | Source/core/loader/FrameFetchContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorPageAgent.cpp

diff --git a/Source/core/inspector/InspectorPageAgent.cpp b/Source/core/inspector/InspectorPageAgent.cpp

index 00bef931dd8f4d206db291a4168dbd305efb8a0c..6bde763e6f3e901a7438dc5a269284c11b7c3a00 100644

--- a/Source/core/inspector/InspectorPageAgent.cpp

+++ b/Source/core/inspector/InspectorPageAgent.cpp

@@ -128,6 +128,9 @@ static bool prepareResourceBuffer(Resource* cachedResource, bool* hasZeroSize)

if (!cachedResource)

return false;

+ if (cachedResource->dataBufferingPolicy() == DoNotBufferData)

+ return false;

// Zero-sized resources don't have data at all -- so fake the empty buffer, instead of indicating error by returning 0.

if (!cachedResource->encodedSize()) {

*hasZeroSize = true;