Use downloadToFile option when XHR downloads a Blob

Source/core/inspector/InspectorInstrumentation.idl

 /*
 * Copyright (C) 2013 Google Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
 *     * Redistributions in binary form must reproduce the above
@@ skipping 264 matching lines @@
 
     [Inline=Forward]
     void continueWithPolicyDownload(Frame* frame, DocumentLoader* loader, unsigned long identifier, const ResourceResponse& r);
 
     [Inline=Forward]
     void continueWithPolicyIgnore(Frame* frame, DocumentLoader* loader, unsigned long identifier, const ResourceResponse& r);
 
     [Resource]
     void didReceiveData(Frame*, unsigned long identifier, const char* data, int dataLength, int encodedDataLength);
 
+    [Resource]
+    void didReceiveDataWithoutData(Frame*, unsigned long identifier, int dataLength, int encodedDataLength);

[eustas, 2013/09/19 04:52:37]

The method name doesn't sound good.

Why don't reuse "didReceiveData" and clarify that data could be null?

[yusukesuzuki, 2013/09/19 05:13:58]

Since didDownloadData always has no data, I think that clarifying it by function
signature is better.
But reusing "didReceiveData" and adding comment about that is also reasonable.

[yusukesuzuki, 2013/09/19 05:33:06]

Is it more preferable reusing "didReceiveData"?

[yusukesuzuki, 2013/09/19 15:41:21]

Done. Thanks for your suggestion.

+
     [Timeline, Resource]
     void didFinishLoading(Frame* frame, unsigned long identifier, DocumentLoader*, double finishTime);
 
     [Resource]
     void didReceiveCORSRedirectResponse(Frame*, unsigned long identifier, DocumentLoader*, const ResourceResponse&, ResourceLoader*);
 
     [Timeline, Resource, Console] // Console should come AFTER Resource notification, front-end relies on this.
     void didFailLoading(Frame* frame, unsigned long identifier, DocumentLoader*, const ResourceError&);
 
     [Resource]
@@ skipping 225 matching lines @@
 interface InspectorCanvasInstrumentation {
 
 #include "bindings/v8/ScriptObject.h"
 
     [Canvas]
     ScriptObject wrapCanvas2DRenderingContextForInstrumentation(Document*, const ScriptObject&);
 
     [Canvas]
     ScriptObject wrapWebGLRenderingContextForInstrumentation(Document*, const ScriptObject&);
 }