Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 23444052: MediaStream API: Updating NavigatorUserMediaError (Closed)

Created:
7 years, 3 months ago by Tommy Widenflycht
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, tommyw+watchlist_chromium.org, eae+blinkwatch, dglazkov+blink
Visibility:
Public.

Description

MediaStream API: Updating NavigatorUserMediaError Updating NavigatorUserMediaError both to reflect the latest spec but also to make it a bit cleaner. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157697

Patch Set 1 #

Patch Set 2 : Added a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -29 lines) Patch
M LayoutTests/fast/mediastream/getusermedia.html View 1 2 chunks +5 lines, -1 line 0 comments Download
M LayoutTests/fast/mediastream/getusermedia-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/mediastream/NavigatorUserMediaError.h View 1 chunk +11 lines, -4 lines 0 comments Download
A + Source/modules/mediastream/NavigatorUserMediaError.cpp View 1 chunk +13 lines, -9 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/modules.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/testing/runner/MockConstraints.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/testing/runner/MockConstraints.cpp View 1 3 chunks +10 lines, -3 lines 0 comments Download
M Source/testing/runner/WebUserMediaClientMock.cpp View 1 3 chunks +44 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tommy Widenflycht
7 years, 3 months ago (2013-09-12 08:58:22 UTC) #1
Tommy Widenflycht
7 years, 3 months ago (2013-09-12 11:51:16 UTC) #2
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-12 19:22:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/23444052/5001
7 years, 3 months ago (2013-09-12 19:22:30 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-12 20:22:27 UTC) #5
Message was sent while issue was closed.
Change committed as 157697

Powered by Google App Engine
This is Rietveld 408576698