Issue 23444030: Remove unsupported Blink CPUs from CPU.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23444030: Remove unsupported Blink CPUs from CPU.h (Closed)

Created:
7 years, 3 months ago by Chris Evans

Modified:
7 years, 3 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove unsupported Blink CPUs from CPU.h Whilst removing the usages of the removed CPU defines, I came across WEBCORE_NAVIGATOR_PLATFORM. Blink sets this value in the gyp file for most platforms, so additional code can be removed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157035

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -97 lines)			Patch
M	Source/core/page/NavigatorID.cpp	View	2 chunks	+6 lines, -16 lines	0 comments	Download
M	Source/wtf/CPU.h	View	2 chunks	+0 lines, -77 lines	0 comments	Download
M	Source/wtf/StdLibExtras.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/wtf/dtoa.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/wtf/dtoa/utils.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Chris Evans

(Compile checks in progress; I want to make sure Android etc. handles WEBCORE_NAVIGATOR_PLATFORM as expected)

7 years, 3 months ago (2013-08-30 22:12:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/23444030/1

7 years, 3 months ago (2013-08-30 22:54:31 UTC) #4

Message was sent while issue was closed.

Change committed as 157035

Expand Messages | Collapse Messages