Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 23442026: Media Galleries API Picasa: Fix PicasaFileUtil GetInfoSync minor bug. (Closed)

Created:
7 years, 3 months ago by tommycli
Modified:
7 years, 3 months ago
CC:
chromium-reviews, Lei Zhang, tzik+watch_chromium.org, tommycli, Greg Billock, kinuko+watch
Visibility:
Public.

Description

Media Galleries API Picasa: Fix PicasaFileUtil GetInfoSync minor bug. NativeMediaFileUtil allows GetInfoSync to be called with a NULL |platform_path|. This change brings PicasaFileUtil behavior in line with that. BUG=151701 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/media_galleries/fileapi/picasa_file_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommycli
vandebo: Needed before end-to-end test can go in.
7 years, 3 months ago (2013-09-16 18:58:37 UTC) #1
vandebo (ex-Chrome)
LGTM
7 years, 3 months ago (2013-09-16 20:15:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/23442026/1
7 years, 3 months ago (2013-09-16 20:36:26 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 03:37:56 UTC) #4
Message was sent while issue was closed.
Change committed as 223521

Powered by Google App Engine
This is Rietveld 408576698