Add loop implementation for HTML5 Video on Android

Add loop implementation for HTML5 Video on Android

Implement playback looping in WebMediaPlayerAndroid

BUG=285965
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222888

[qinmin, 2013-09-10 19:26:45]

lgtm % nit

https://codereview.chromium.org/23442021/diff/1/content/renderer/media/androi...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/23442021/diff/1/content/renderer/media/androi...
content/renderer/media/android/webmediaplayer_android.cc:599: if ((seeking_) &&
(pending_seek_ == 0))
nit: no () for seeking_ and pending_seek_ == 0

[akuoch, 2013-09-12 16:55:06]

On 2013/09/10 19:26:45, qinmin wrote:
> lgtm % nit
> 
>
https://codereview.chromium.org/23442021/diff/1/content/renderer/media/androi...
> File content/renderer/media/android/webmediaplayer_android.cc (right):
> 
>
https://codereview.chromium.org/23442021/diff/1/content/renderer/media/androi...
> content/renderer/media/android/webmediaplayer_android.cc:599: if ((seeking_)
&&
> (pending_seek_ == 0))
> nit: no () for seeking_ and pending_seek_ == 0

Thx for the review, nit done.

[commit-bot: I haz the power, 2013-09-12 18:35:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akuoch@codeaurora.org/23442021/4001

[commit-bot: I haz the power, 2013-09-12 18:35:10]

Failed to apply patch for
content/renderer/media/android/webmediaplayer_android.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/renderer/media/android/webmediaplayer_android.cc
  Hunk #1 FAILED at 98.
  Hunk #2 succeeded at 587 (offset -1 lines).
  Hunk #3 succeeded at 611 (offset -1 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
content/renderer/media/android/webmediaplayer_android.cc.rej

Patch:       content/renderer/media/android/webmediaplayer_android.cc
Index: content/renderer/media/android/webmediaplayer_android.cc
diff --git a/content/renderer/media/android/webmediaplayer_android.cc
b/content/renderer/media/android/webmediaplayer_android.cc
index
8eda65f107f7c946b7038346d0e2128b0192464e..104b85d5bbd1be00d691d264e4937ee939d053e8
100644
--- a/content/renderer/media/android/webmediaplayer_android.cc
+++ b/content/renderer/media/android/webmediaplayer_android.cc
@@ -98,6 +98,7 @@ WebMediaPlayerAndroid::WebMediaPlayerAndroid(
       media_stream_client_(NULL),
 #endif  // defined(GOOGLE_TV)
       source_type_(MediaPlayerAndroid::SOURCE_TYPE_URL),
+      pending_playback_(false),
       proxy_(proxy),
       current_time_(0),
       media_log_(media_log) {
@@ -588,6 +589,15 @@ void WebMediaPlayerAndroid::OnPlaybackComplete() {
   // current time to media duration when OnPlaybackComplete() get called.
   OnTimeUpdate(duration_);
   client_->timeChanged();
+
+  // if the loop attribute is set, timeChanged() will update the current time
+  // to 0. It will perform a seek to 0. As the requests to the renderer
+  // process are sequential, the OnSeekCompelete() will only occur
+  // once OnPlaybackComplete() is done. As the playback can only be executed
+  // upon completion of OnSeekComplete(), the request needs to be saved.
+  is_playing_ = false;
+  if (seeking_ && pending_seek_ == 0)
+    pending_playback_ = true;
 }
 
 void WebMediaPlayerAndroid::OnBufferingUpdate(int percentage) {
@@ -603,6 +613,11 @@ void WebMediaPlayerAndroid::OnSeekComplete(base::TimeDelta
current_time) {
   UpdateReadyState(WebMediaPlayer::ReadyStateHaveEnoughData);
 
   client_->timeChanged();
+
+  if (pending_playback_) {
+    play();
+    pending_playback_ = false;
+  }
 }
 
 void WebMediaPlayerAndroid::OnMediaError(int error_type) {

[commit-bot: I haz the power, 2013-09-12 19:56:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akuoch@codeaurora.org/23442021/11001

[commit-bot: I haz the power, 2013-09-12 22:33:13]

Change committed as 222888