Issue 23441060: DevTools: Improve design of WebViews available for inspection in chrome://inspect

Issue 23441060: DevTools: Improve design of WebViews available for inspection in chrome://inspect (Closed)

Created:
7 years, 3 months ago by Vladislav Kaznacheev

Modified:
7 years, 3 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, arv+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: Improve design of WebViews available for inspection in chrome://inspect BUG=289178 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223385

Patch Set 2 : Rewrote JS for clarity #

Patch Set 3 : Rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -52 lines)			Patch
M	chrome/browser/devtools/devtools_adb_bridge.h	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_adb_bridge.cc	View	1	3 chunks	+44 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/inspect/inspect.css	View	1	3 chunks	+27 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/inspect/inspect.js	View	1	7 chunks	+104 lines, -44 lines	0 comments	Download
M	chrome/browser/ui/webui/inspect_ui.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/23441060/diff/1/chrome/browser/devtools/devtools_adb_bridge.h File chrome/browser/devtools/devtools_adb_bridge.h (right): https://codereview.chromium.org/23441060/diff/1/chrome/browser/devtools/devtools_adb_bridge.h#newcode217 chrome/browser/devtools/devtools_adb_bridge.h:217: int screenWidth_; screen_width_. I'd also use gfx::Size.

7 years, 3 months ago (2013-09-13 13:36:04 UTC) #2

pfeldman

https://codereview.chromium.org/23441060/diff/1/chrome/browser/ui/webui/inspect_ui.cc File chrome/browser/ui/webui/inspect_ui.cc (right): https://codereview.chromium.org/23441060/diff/1/chrome/browser/ui/webui/inspect_ui.cc#newcode699 chrome/browser/ui/webui/inspect_ui.cc:699: // Pass the screen dimensions in the browser object ...

7 years, 3 months ago (2013-09-13 13:38:41 UTC) #3

Vladislav Kaznacheev

PTAL https://codereview.chromium.org/23441060/diff/1/chrome/browser/ui/webui/inspect_ui.cc File chrome/browser/ui/webui/inspect_ui.cc (right): https://codereview.chromium.org/23441060/diff/1/chrome/browser/ui/webui/inspect_ui.cc#newcode699 chrome/browser/ui/webui/inspect_ui.cc:699: // Pass the screen dimensions in the browser ...

7 years, 3 months ago (2013-09-16 10:07:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/23441060/11001

7 years, 3 months ago (2013-09-16 13:34:24 UTC) #6

Message was sent while issue was closed.

Change committed as 223385

Expand Messages | Collapse Messages