drive: Enable recursive fast-fetch.

drive: Enable recursive fast-fetch.

- LoadDirectoryIfNeeded calls GetResourceEntryByPath for directory metadata.
- GetResourceEntryByPath calls LoadDirectoryIfNeeded for its parent if needed.

The cycle enables to fetch deep entries at any time without waiting for
the full feed nor user to dig down the hierarchy from the root.

Along the way, I removed the handling of  ReadDirectoryByPath("drive/other")
that waited the full feed to arrive. By removing it, all FileSystem
operations are now clearly ensured not blocked by full feed fetching.
Listing up "drive/other" is meaningless; Files.app never does that.

BUG=285614
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221712

[kinaba, 2013-09-05 09:33:13]

Essential change is in one line (line 710 -> 714 in Patch Set 1), but
some clarifications and clean-ups are added.

[kinaba, 2013-09-05 09:33:41]

Oops, I'll fix the test tomorrow.

[kinaba, 2013-09-06 03:06:18]

On 2013/09/05 09:33:41, kinaba wrote:
> Oops, I'll fix the test tomorrow.

Done.

[hidehiko, 2013-09-06 04:18:01]

lgtm

[satorux1, 2013-09-06 04:28:00]

Would it be possible to write a new test for this behavior?

[kinaba, 2013-09-06 08:21:41]

On 2013/09/06 04:28:00, satorux1 wrote:
> Would it be possible to write a new test for this behavior?

Done. (Need https://codereview.chromium.org/23670006/ for the modified test to
correctly run).

[satorux1, 2013-09-06 08:32:25]

LGTM with nits.

https://codereview.chromium.org/23441049/diff/20001/chrome/browser/chromeos/d...
File chrome/browser/chromeos/drive/file_system_unittest.cc (right):

https://codereview.chromium.org/23441049/diff/20001/chrome/browser/chromeos/d...
chrome/browser/chromeos/drive/file_system_unittest.cc:384: // to test the "fast
fetch" feature is properly working.
"fast fetch" -> recursive "fast fetch"

https://codereview.chromium.org/23441049/diff/20001/chrome/browser/chromeos/d...
chrome/browser/chromeos/drive/file_system_unittest.cc:387: const base::FilePath
kFilePath(FILE_PATH_LITERAL("drive/root/File 1.txt"));
could you make this one level deeper, to make it more obvious that the recursive
fast fetch is working.

[kinaba, 2013-09-06 10:12:14]

https://codereview.chromium.org/23441049/diff/20001/chrome/browser/chromeos/d...
File chrome/browser/chromeos/drive/file_system_unittest.cc (right):

https://codereview.chromium.org/23441049/diff/20001/chrome/browser/chromeos/d...
chrome/browser/chromeos/drive/file_system_unittest.cc:384: // to test the "fast
fetch" feature is properly working.
On 2013/09/06 08:32:25, satorux1 wrote:
> "fast fetch" -> recursive "fast fetch"

Done.

https://codereview.chromium.org/23441049/diff/20001/chrome/browser/chromeos/d...
chrome/browser/chromeos/drive/file_system_unittest.cc:387: const base::FilePath
kFilePath(FILE_PATH_LITERAL("drive/root/File 1.txt"));
On 2013/09/06 08:32:25, satorux1 wrote:
> could you make this one level deeper, to make it more obvious that the
recursive
> fast fetch is working.

Done.

[hidehiko, 2013-09-06 10:19:23]

lgtm

[commit-bot: I haz the power, 2013-09-06 12:18:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/23441049/31001

[commit-bot: I haz the power, 2013-09-06 15:14:37]

Change committed as 221712