content/browser/device_orientation/data_fetcher_shared_memory_mac.cc - Issue 23441047: Fix race condition in DataFetcherSharedMemoryBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_orientation/data_fetcher_shared_memory_mac.cc

Issue 23441047: Fix race condition in DataFetcherSharedMemoryBase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/device_orientation/data_fetcher_shared_memory_default.cc ('k') | tools/valgrind/tsan/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_orientation/data_fetcher_shared_memory_mac.cc

diff --git a/content/browser/device_orientation/data_fetcher_shared_memory_mac.cc b/content/browser/device_orientation/data_fetcher_shared_memory_mac.cc

index 5c958cb27505c28643374bfd9efe20a453d635a6..54793837d75e1179168fc61cd4fed394b975f11e 100644

--- a/content/browser/device_orientation/data_fetcher_shared_memory_mac.cc

+++ b/content/browser/device_orientation/data_fetcher_shared_memory_mac.cc

@@ -115,10 +115,8 @@ bool DataFetcherSharedMemory::IsPolling() const {

return true;

}

-bool DataFetcherSharedMemory::Start(ConsumerType consumer_type) {

+bool DataFetcherSharedMemory::Start(ConsumerType consumer_type, void* buffer) {

DCHECK(base::MessageLoop::current() == GetPollingMessageLoop());

- void* buffer = GetSharedMemoryBuffer(consumer_type);

DCHECK(buffer);

switch (consumer_type) {

« no previous file with comments | « content/browser/device_orientation/data_fetcher_shared_memory_default.cc ('k') | tools/valgrind/tsan/suppressions.txt » ('j') | no next file with comments »