Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: content/browser/device_orientation/data_fetcher_shared_memory.h

Issue 23441047: Fix race condition in DataFetcherSharedMemoryBase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/device_orientation/data_fetcher_shared_memory_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/device_orientation/data_fetcher_shared_memory.h
diff --git a/content/browser/device_orientation/data_fetcher_shared_memory.h b/content/browser/device_orientation/data_fetcher_shared_memory.h
index cbc274a51d2bdc74767a79441a1b512ea6a87801..1b5091ea23c6be24db327bf3bdd295f840a5e841 100644
--- a/content/browser/device_orientation/data_fetcher_shared_memory.h
+++ b/content/browser/device_orientation/data_fetcher_shared_memory.h
@@ -7,10 +7,12 @@
#include "content/browser/device_orientation/data_fetcher_shared_memory_base.h"
-#if defined(OS_MACOSX)
+#if !defined(OS_ANDROID)
#include "content/common/device_motion_hardware_buffer.h"
#include "content/common/device_orientation/device_orientation_hardware_buffer.h"
+#endif
+#if defined(OS_MACOSX)
class SuddenMotionSensor;
#endif
@@ -24,16 +26,17 @@ class CONTENT_EXPORT DataFetcherSharedMemory
virtual ~DataFetcherSharedMemory();
private:
-
- virtual bool Start(ConsumerType consumer_type) OVERRIDE;
+ virtual bool Start(ConsumerType consumer_type, void* buffer) OVERRIDE;
virtual bool Stop(ConsumerType consumer_type) OVERRIDE;
+#if !defined(OS_ANDROID)
+ DeviceMotionHardwareBuffer* motion_buffer_;
+ DeviceOrientationHardwareBuffer* orientation_buffer_;
+#endif
#if defined(OS_MACOSX)
virtual void Fetch(unsigned consumer_bitmask) OVERRIDE;
virtual bool IsPolling() const OVERRIDE;
- DeviceMotionHardwareBuffer* motion_buffer_;
- DeviceOrientationHardwareBuffer* orientation_buffer_;
scoped_ptr<SuddenMotionSensor> sudden_motion_sensor_;
#endif
« no previous file with comments | « no previous file | content/browser/device_orientation/data_fetcher_shared_memory_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698