Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 23441046: Ignore use requirement from never run code (Closed)

Created:
7 years, 3 months ago by weiliang.lin2
Modified:
7 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@master
Visibility:
Public.

Description

Ignore use requirement from never run code BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/hydrogen-instructions.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
weiliang.lin2
The use requirement from non-run code would lead to aggressive representation change. A micro to ...
7 years, 3 months ago (2013-09-04 14:04:00 UTC) #1
Toon Verwaest
LGTM. Nice catch!
7 years, 3 months ago (2013-09-04 14:54:56 UTC) #2
Toon Verwaest
7 years, 3 months ago (2013-09-04 15:25:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16538 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698