chrome/browser/extensions/api/system_display/display_info_provider_mac.cc - Issue 23441032: [SystemInfo API] Rewrite DisplayInfoProvider without SystemInfoProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_display/display_info_provider_mac.cc

Issue 23441032: [SystemInfo API] Rewrite DisplayInfoProvider without SystemInfoProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use valid display id. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/system_display/display_info_provider_gtk.cc ('k') | chrome/browser/extensions/api/system_display/display_info_provider_win.cc » ('j') | chrome/browser/extensions/api/system_display/system_display_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_display/display_info_provider_mac.cc

diff --git a/chrome/browser/extensions/api/system_display/display_info_provider_mac.cc b/chrome/browser/extensions/api/system_display/display_info_provider_mac.cc

index 3776bf90bb496b07dfd5eb437a4dd5d98c7bfa41..84a610542ce54614c2b3c3b2a1b95cc887a81831 100644

--- a/chrome/browser/extensions/api/system_display/display_info_provider_mac.cc

+++ b/chrome/browser/extensions/api/system_display/display_info_provider_mac.cc

@@ -6,13 +6,11 @@

namespace extensions {

-void DisplayInfoProvider::SetInfo(

- const std::string& display_id,

+bool DisplayInfoProvider::SetInfo(const std::string& display_id,

const api::system_display::DisplayProperties& info,

- const SetInfoCallback& callback) {

- base::MessageLoopProxy::current()->PostTask(

- FROM_HERE,

- base::Bind(callback, false, "Not implemented"));

+ std::string* error) {

+ *error = "Not Implemented";

+ return false;

}

void DisplayInfoProvider::UpdateDisplayUnitInfoForPlatform(