chrome/browser/extensions/api/system_display/display_info_provider_chromeos.cc - Issue 23441032: [SystemInfo API] Rewrite DisplayInfoProvider without SystemInfoProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_display/display_info_provider_chromeos.cc

Issue 23441032: [SystemInfo API] Rewrite DisplayInfoProvider without SystemInfoProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing head file Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/system_display/display_info_provider.cc ('K') | « chrome/browser/extensions/api/system_display/display_info_provider.cc ('k') | chrome/browser/extensions/api/system_display/display_info_provider_mac.cc » ('j') | chrome/browser/extensions/api/system_display/system_display_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_display/display_info_provider_chromeos.cc

diff --git a/chrome/browser/extensions/api/system_display/display_info_provider_chromeos.cc b/chrome/browser/extensions/api/system_display/display_info_provider_chromeos.cc

index dba99e0ab1f4756dbdfb4f2fa25ad5a2033b9edb..34e8532938c34b07e682eb8a23b735f38e4cfe36 100644

--- a/chrome/browser/extensions/api/system_display/display_info_provider_chromeos.cc

+++ b/chrome/browser/extensions/api/system_display/display_info_provider_chromeos.cc

@@ -355,14 +355,10 @@ bool SetInfoImpl(const std::string& display_id_str,

} // namespace

-void DisplayInfoProvider::SetInfo(const std::string& display_id,

+bool DisplayInfoProvider::SetInfo(const std::string& display_id,

const DisplayProperties& info,

- const SetInfoCallback& callback) {

- std::string error;

- bool success = SetInfoImpl(display_id, info, &error);

- base::MessageLoopProxy::current()->PostTask(

- FROM_HERE,

- base::Bind(callback, success, error));

+ std::string* error) {

+ return SetInfoImpl(display_id, info, &error);

Hongbo Min 2013/09/04 06:58:02 Right now SetInfoImpl has a signature "SetInfoImpl

Haojian Wu 2013/09/04 12:11:33 Done. Passing |error| directly instead.

}

void DisplayInfoProvider::UpdateDisplayUnitInfoForPlatform(