[SystemInfo API] Rewrite DisplayInfoProvider without SystemInfoProvider.

chrome/browser/extensions/api/system_display/system_display_apitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/system_display/system_display_api.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/extensions/api/system_display/display_info_provider.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
+#include "ui/gfx/display.h"
+#include "ui/gfx/display_observer.h"
+#include "ui/gfx/screen.h"
 
 namespace utils = extension_function_test_utils;
 
 namespace extensions {
 
 using api::system_display::Bounds;
 using api::system_display::DisplayUnitInfo;
+using gfx::Screen;
+
+class MockScreen : public Screen {
+ public:
+  MockScreen() {
+    for (int i = 0; i < 4; i++) {
+      gfx::Rect bounds(0, 0, 1280, 720);
+      gfx::Rect work_area(0, 0, 960, 720);
+      gfx::Display display(i, bounds);
+      display.set_work_area(work_area);
+      displays_.push_back(display);
+    }
+  }
+  virtual ~MockScreen() {}
+
+ protected:
+  // Overridden from gfx::Screen:
+  virtual bool IsDIPEnabled() OVERRIDE { return true; }
+  virtual gfx::Point GetCursorScreenPoint() OVERRIDE  { return gfx::Point(); }
+  virtual gfx::NativeWindow GetWindowAtCursorScreenPoint() OVERRIDE {
+    return gfx::NativeWindow();
+  }
+  virtual int GetNumDisplays() const OVERRIDE {
+    return displays_.size();
+  }
+  virtual std::vector<gfx::Display> GetAllDisplays() const OVERRIDE {
+    return displays_;
+  }
+  virtual gfx::Display GetDisplayNearestWindow(
+      gfx::NativeView window) const OVERRIDE {
+    return gfx::Display();
+  }
+  virtual gfx::Display GetDisplayNearestPoint(
+      const gfx::Point& point) const OVERRIDE {
+    return gfx::Display();
+  }
+  virtual gfx::Display GetDisplayMatching(
+      const gfx::Rect& match_rect) const OVERRIDE {
+    return gfx::Display();
+  }
+  virtual gfx::Display GetPrimaryDisplay() const OVERRIDE {
+    return displays_[0];
+  }
+  virtual void AddObserver(gfx::DisplayObserver* observer) OVERRIDE {}
+  virtual void RemoveObserver(gfx::DisplayObserver* observer) OVERRIDE {}
+
+ private:
+  std::vector<gfx::Display> displays_;
+
+  DISALLOW_COPY_AND_ASSIGN(MockScreen);
+};
+
 
 class MockDisplayInfoProvider : public DisplayInfoProvider {
  public:
   MockDisplayInfoProvider() {}
 
-  virtual bool QueryInfo() OVERRIDE {
-    info_.clear();
-    for (int i = 0; i < 4; i++) {
-      linked_ptr<DisplayUnitInfo> unit(new DisplayUnitInfo());
-      unit->id = base::IntToString(i);
-      unit->name = "DISPLAY NAME FOR " + unit->id;
-      if (i == 1)
-        unit->mirroring_source_id = "0";
-      unit->is_primary = i == 0 ? true : false;
-      unit->is_internal = i == 0 ? true : false;
-      unit->is_enabled = true;
-      unit->rotation = (90 * i) % 360;
-      unit->dpi_x = 96.0;
-      unit->dpi_y = 96.0;
-      unit->bounds.left = 0;
-      unit->bounds.top = 0;
-      unit->bounds.width = 1280;
-      unit->bounds.height = 720;
-      if (i == 0) {
-        unit->overscan.left = 20;
-        unit->overscan.top = 40;
-        unit->overscan.right = 60;
-        unit->overscan.bottom = 80;
-      }
-      unit->work_area.left = 0;
-      unit->work_area.top = 0;
-      unit->work_area.width = 960;
-      unit->work_area.height = 720;
-      info_.push_back(unit);
-    }
-    return true;
-  }
+  virtual ~MockDisplayInfoProvider() {}
 
-  virtual void SetInfo(
+  virtual bool SetInfo(
       const std::string& display_id,
       const api::system_display::DisplayProperties& params,
-      const SetInfoCallback& callback) OVERRIDE {
+      std::string* error) OVERRIDE {
     // Should get called only once per test case.
     EXPECT_FALSE(set_info_value_);
     set_info_value_ = params.ToValue();
     set_info_display_id_ = display_id;
-    callback.Run(true, std::string());
+    return true;
   }
 
   scoped_ptr<base::DictionaryValue> GetSetInfoValue() {
     return set_info_value_.Pass();
   }
 
   std::string GetSetInfoDisplayId() const {
     return set_info_display_id_;
   }
 
  private:
-  virtual ~MockDisplayInfoProvider() {}
+  // Update the content of the |unit| obtained for |display| using
+  // platform specific method.
+  virtual void UpdateDisplayUnitInfoForPlatform(
+      const gfx::Display& display,
+      extensions::api::system_display::DisplayUnitInfo* unit) OVERRIDE {
+    int64 id = display.id();
+    unit->name = "DISPLAY NAME FOR " + base::Int64ToString(id);
+    if (id == 1)
+      unit->mirroring_source_id = "0";
+    unit->is_primary = id == 0 ? true : false;
+    unit->is_internal = id == 0 ? true : false;
+    unit->is_enabled = true;
+    unit->rotation = (90 * id) % 360;
+    unit->dpi_x = 96.0;
+    unit->dpi_y = 96.0;
+    unit->bounds.left = 0;
+    unit->bounds.top = 0;
+    unit->bounds.width = 1280;
+    unit->bounds.height = 720;
+    if (id == 0) {
+      unit->overscan.left = 20;
+      unit->overscan.top = 40;
+      unit->overscan.right = 60;
+      unit->overscan.bottom = 80;
+    }
+    unit->work_area.left = 0;
+    unit->work_area.top = 0;
+    unit->work_area.width = 960;
+    unit->work_area.height = 720;

[oshima, 2013/09/03 23:14:46]

Some of these must be already done in DisplayInfoProvider code?

[Haojian Wu, 2013/09/04 12:11:33]

Yes. Remove it now.

+  }
 
   scoped_ptr<base::DictionaryValue> set_info_value_;
   std::string set_info_display_id_;
 
   DISALLOW_COPY_AND_ASSIGN(MockDisplayInfoProvider);
 };
 
 class SystemDisplayApiTest: public ExtensionApiTest {
  public:
-  SystemDisplayApiTest() {}
+  SystemDisplayApiTest() : screen_(new MockScreen) {
+    gfx::Screen::SetScreenInstance(gfx::SCREEN_TYPE_NATIVE, screen_.get());
+  }
   virtual ~SystemDisplayApiTest() {}
 
   virtual void SetUpOnMainThread() OVERRIDE {
     ExtensionApiTest::SetUpOnMainThread();
     provider_ = new MockDisplayInfoProvider();
-    // The |provider| will be co-owned by the singleton instance.
+    // The |provider_| will be co-owned by the DisplayInfoProvider instance.
     DisplayInfoProvider::InitializeForTesting(provider_);
   }
 
   virtual void CleanUpOnMainThread() OVERRIDE {
-    // Has to be released before the main thread is gone.
-    provider_ = NULL;
     ExtensionApiTest::CleanUpOnMainThread();
   }
 
  protected:
-  scoped_refptr<MockDisplayInfoProvider> provider_;
+  MockDisplayInfoProvider* provider_;
+  scoped_ptr<gfx::Screen> screen_;
 
   DISALLOW_COPY_AND_ASSIGN(SystemDisplayApiTest);
 };
 
 IN_PROC_BROWSER_TEST_F(SystemDisplayApiTest, GetDisplay) {
   ASSERT_TRUE(RunPlatformAppTest("system/display")) << message_;
 }
 
 #if !defined(OS_CHROMEOS)
 IN_PROC_BROWSER_TEST_F(SystemDisplayApiTest, SetDisplay) {
@@ skipping 89 matching lines @@
   EXPECT_EQ(1, utils::GetInteger(overscan, "left"));
   EXPECT_EQ(2, utils::GetInteger(overscan, "top"));
   EXPECT_EQ(3, utils::GetInteger(overscan, "right"));
   EXPECT_EQ(4, utils::GetInteger(overscan, "bottom"));
 
   EXPECT_EQ("display_id", provider_->GetSetInfoDisplayId());
 }
 #endif  // defined(OS_CHROMEOS)
 
 } // namespace extensions