Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

Issue 23441015: Treat USE_ASH is always defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
diff --git a/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc b/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
index e49f670ddf56f8a2fb43772be259923ceee39ed5..9549f031947d7a9e3119c9b92ad67f80e88d3294 100644
--- a/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
+++ b/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
@@ -7,6 +7,9 @@
#include <string>
#include <vector>
+#include "ash/shell.h"
+#include "ash/shell_window_ids.h"
+#include "ash/wm/window_animations.h"
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
#include "base/observer_list.h"
@@ -16,11 +19,6 @@
#include "chromeos/dbus/dbus_thread_manager.h"
#include "ui/views/widget/widget.h"
-#if defined(USE_ASH)
-#include "ash/shell.h"
-#include "ash/shell_window_ids.h"
-#include "ash/wm/window_animations.h"
-#endif // USE_ASH
namespace chromeos {
namespace input_method {
@@ -67,19 +65,14 @@ void CandidateWindowControllerImpl::CreateView() {
// they should use WIDGET_OWNS_NATIVE_WIDGET ownership.
params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
// Show the candidate window always on top
-#if defined(USE_ASH)
params.parent = ash::Shell::GetContainer(
ash::Shell::GetActiveRootWindow(),
ash::internal::kShellWindowId_InputMethodContainer);
-#else
- params.keep_on_top = true;
-#endif
frame_->Init(params);
-#if defined(USE_ASH)
+
views::corewm::SetWindowVisibilityAnimationType(
frame_->GetNativeView(),
views::corewm::WINDOW_VISIBILITY_ANIMATION_TYPE_FADE);
-#endif // USE_ASH
// Create the candidate window.
candidate_window_ = new CandidateWindowView(frame_.get());
@@ -92,11 +85,10 @@ void CandidateWindowControllerImpl::CreateView() {
// Create the infolist window.
infolist_window_.reset(new DelayableWidget);
infolist_window_->Init(params);
-#if defined(USE_ASH)
+
views::corewm::SetWindowVisibilityAnimationType(
infolist_window_->GetNativeView(),
views::corewm::WINDOW_VISIBILITY_ANIMATION_TYPE_FADE);
-#endif // USE_ASH
InfolistWindowView* infolist_view = new InfolistWindowView;
infolist_view->Init();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698