Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: chrome/browser/plugins/plugin_metadata.cc

Issue 23440066: Block NPAPI plugins by default Add Facebook video calling and Google Earth plugins to the tracked l… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/plugins/plugin_metadata_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_metadata.cc
diff --git a/chrome/browser/plugins/plugin_metadata.cc b/chrome/browser/plugins/plugin_metadata.cc
index 5f2fc50ba2748a73ebd8bf3296d1fb7b73cde83d..5f40e06c0a89e79aa34ede5953958147909f7d63 100644
--- a/chrome/browser/plugins/plugin_metadata.cc
+++ b/chrome/browser/plugins/plugin_metadata.cc
@@ -94,9 +94,13 @@ PluginMetadata::SecurityStatus PluginMetadata::GetSecurityStatus(
const content::WebPluginInfo& plugin) const {
if (versions_.empty()) {
#if defined(OS_LINUX)
- // On Linux, unknown plugins require authorization.
+ // On Linux, unknown plugins require authorization.
return SECURITY_STATUS_REQUIRES_AUTHORIZATION;
#else
+ if (plugin.type == content::WebPluginInfo::PLUGIN_TYPE_NPAPI) {
Bernhard Bauer 2013/09/24 18:16:56 This check isn't necessary. Pepper plug-ins are al
Cris Neckar 2013/09/24 18:52:00 Done.
+ // Unknown NPAPI plugins require authorization.
+ return SECURITY_STATUS_REQUIRES_AUTHORIZATION;
+ }
return SECURITY_STATUS_UP_TO_DATE;
#endif
}
« no previous file with comments | « no previous file | chrome/browser/plugins/plugin_metadata_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698