Issue 23440027: Added a new runtime setting for RequireUserGestureForFullscreenRestriction.

Issue 23440027: Added a new runtime setting for RequireUserGestureForFullscreenRestriction. (Closed)

Created:
7 years, 3 months ago by whywhat

Modified:
7 years, 3 months ago

Reviewers:
Peter Beverloo, abarth-chromium

CC:
blink-reviews, jamesr, nessy, eae+blinkwatch, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Added a new runtime setting for RequireUserGestureForFullscreenRestriction. Control the restriction requiring user gesture for the media element to enter fullscreen with the new mediaFullscreenRequiresUserGesture setting. BUG=288678 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157643

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added LayoutTest for the new setting when it's false (true is covered). #

Patch Set 3 : Fixed the -actual.txt by appending two blank lines. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -5 lines)			Patch
A	LayoutTests/media/video-enter-fullscreen-without-user-gesture.html	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download
A	LayoutTests/media/video-enter-fullscreen-without-user-gesture-expected.txt	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	LayoutTests/media/video-play-require-user-gesture.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	Source/core/page/Settings.in	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/WebSettingsImpl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/WebSettingsImpl.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	public/web/WebSettings.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

I can't view https://code.google.com/p/chromium/issues/detail?id=288678. Can you explain why we'd want to set this value to ...

7 years, 3 months ago (2013-09-11 18:26:51 UTC) #2

whywhat

Discusses the reasons offline. Added the test and verified it passes locally. https://codereview.chromium.org/23440027/diff/1/LayoutTests/media/video-play-require-user-gesture.html File LayoutTests/media/video-play-require-user-gesture.html ...

7 years, 3 months ago (2013-09-11 21:11:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avayvod@chromium.org/23440027/3001

7 years, 3 months ago (2013-09-11 22:56:22 UTC) #5

Message was sent while issue was closed.

Change committed as 157643

Expand Messages | Collapse Messages