Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 23440010: Enable InstantExtendedPrefetchTests (Closed)

Created:
7 years, 3 months ago by kmadhusu
Modified:
7 years, 3 months ago
Reviewers:
samarth
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Visibility:
Public.

Description

Enable InstantExtendedPrefetchTests. Created a default URLFetcherFactory to fix the flaky tests. BUG=280247 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220471

Patch Set 1 #

Patch Set 2 : Created a default URLFetcherFactory to fix the flaky test. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 2 6 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/ui/search/instant_test_utils.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kmadhusu
Follow up of crrev.com/23620004. Please review. Thanks.
7 years, 3 months ago (2013-08-27 21:42:46 UTC) #1
samarth
lgtm
7 years, 3 months ago (2013-08-29 16:53:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/23440010/16001
7 years, 3 months ago (2013-08-29 16:54:34 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-08-29 19:31:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/23440010/16001
7 years, 3 months ago (2013-08-29 20:20:22 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 01:38:30 UTC) #6
Message was sent while issue was closed.
Change committed as 220471

Powered by Google App Engine
This is Rietveld 408576698