Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9278)

Unified Diff: chromeos/printing/printer_translator_unittest.cc

Issue 2343983004: Add PPDProvider barebones implementation and associated cache skeleton. (Closed)
Patch Set: Initial PPDProvider/PPDCache implementation. Also, add associated unittests. This doesn't plumb th… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/printing/printer_configuration.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/printing/printer_translator_unittest.cc
diff --git a/chromeos/printing/printer_translator_unittest.cc b/chromeos/printing/printer_translator_unittest.cc
index 51edff9df7d5716b97080cb05b937dac2af39ed1..4b5556296af7322c084f47676579de05e6324cf4 100644
--- a/chromeos/printing/printer_translator_unittest.cc
+++ b/chromeos/printing/printer_translator_unittest.cc
@@ -104,8 +104,6 @@ TEST(PrinterTranslatorTest, PrinterToPrefPpdReferenceLazy) {
EXPECT_FALSE(actual->HasKey("ppd_reference.effective_model"));
}
-// FIXME add a test that we don't set fields that are empty.
-
TEST(PrinterTranslatorTest, PrefToPrinterRoundTrip) {
base::DictionaryValue preference;
preference.SetString("id", kGUID);
« no previous file with comments | « chromeos/printing/printer_configuration.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698