Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 23437036: use a black brush instead of a null brush for window background (Closed)

Created:
7 years, 3 months ago by scottmg
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, cpu_(ooo_6.6-7.5)
Visibility:
Public.

Description

use a black brush instead of a null brush for window background Yet another attempt at fixing black flash and window garbage on resize in Win8. I don't have any good reason why this should make any difference, but http://msdn.microsoft.com/en-us/library/windows/desktop/bb688195(v=vs.85).aspx#extending specifically mentions using GetStockObject(BLACK_BRUSH) so perhaps this triggers some magic behavior. R=sky@chromium.org BUG=290481 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gfx/win/window_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
7 years, 3 months ago (2013-09-13 22:16:01 UTC) #1
sky
LGTM
7 years, 3 months ago (2013-09-16 20:55:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23437036/1
7 years, 3 months ago (2013-09-16 23:04:04 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=198145
7 years, 3 months ago (2013-09-17 01:38:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23437036/1
7 years, 3 months ago (2013-09-17 02:24:04 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=198221
7 years, 3 months ago (2013-09-17 07:55:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23437036/1
7 years, 3 months ago (2013-09-17 16:38:41 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 18:39:48 UTC) #8
Message was sent while issue was closed.
Change committed as 223645

Powered by Google App Engine
This is Rietveld 408576698