Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1701)

Issue 23437029: Catching for "No such process" in tear_down_git (Closed)

Created:
7 years, 3 months ago by rmistry
Modified:
7 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, skiabot_google.com
Visibility:
Public.

Description

Catching for "No such process" in tear_down_git similar to tear_down_svn. I cannot reproduce the test failures in https://chromiumcodereview.appspot.com/24047003/ but I figure there must be a good reason tear_down_svn had this check so adding it to tear_down_git. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=222785

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M testing_support/fake_repos.py View 1 2 chunks +6 lines, -2 lines 0 comments Download
M tests/checkout_test.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rmistry
7 years, 3 months ago (2013-09-12 12:46:59 UTC) #1
M-A Ruel
lgtm with nit https://codereview.chromium.org/23437029/diff/1/testing_support/fake_repos.py File testing_support/fake_repos.py (right): https://codereview.chromium.org/23437029/diff/1/testing_support/fake_repos.py#newcode272 testing_support/fake_repos.py:272: except OSError, e: except OSError as ...
7 years, 3 months ago (2013-09-12 12:55:57 UTC) #2
rmistry
https://codereview.chromium.org/23437029/diff/1/testing_support/fake_repos.py File testing_support/fake_repos.py (right): https://codereview.chromium.org/23437029/diff/1/testing_support/fake_repos.py#newcode272 testing_support/fake_repos.py:272: except OSError, e: On 2013/09/12 12:55:58, M-A Ruel wrote: ...
7 years, 3 months ago (2013-09-12 13:56:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmistry@google.com/23437029/6001
7 years, 3 months ago (2013-09-12 14:38:01 UTC) #4
commit-bot: I haz the power
Presubmit check for 23437029-6001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 3 months ago (2013-09-12 14:39:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmistry@google.com/23437029/6001
7 years, 3 months ago (2013-09-12 14:40:31 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-12 14:42:25 UTC) #7
Message was sent while issue was closed.
Change committed as 222785

Powered by Google App Engine
This is Rietveld 408576698