[Drive] Add converter from ResourceEntry to FileResource

[Drive] Add converter from ResourceEntry to FileResource

BUG=240165
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222006

[tzik, 2013-09-09 03:26:03]

PTL, Abe-san.
Before we migrate our DriveServiceInterface from GData WAPI to Drive API, we
need a converter between them.

[hidehiko, 2013-09-09 03:51:59]

https://codereview.chromium.org/23437026/diff/3001/chrome/browser/drive/gdata...
File chrome/browser/drive/gdata_wapi_service.cc (right):

https://codereview.chromium.org/23437026/diff/3001/chrome/browser/drive/gdata...
chrome/browser/drive/gdata_wapi_service.cc:163:
file->set_shared_with_me_date(base::Time::Now());
Could you add comment, why this doesn't break the chrome and why it is
impossible to assign the valid shared_with_me_date, here?

https://codereview.chromium.org/23437026/diff/3001/chrome/browser/drive/gdata...
chrome/browser/drive/gdata_wapi_service.cc:176: for
(ScopedVector<Link>::const_iterator itr = entry.links().begin();
IIUC, we use size_t i for iteration of vector in drive's code. Could you use it
for consistency?

https://codereview.chromium.org/23437026/diff/11001/chrome/browser/drive/gdat...
File chrome/browser/drive/gdata_wapi_service.h (right):

https://codereview.chromium.org/23437026/diff/11001/chrome/browser/drive/gdat...
chrome/browser/drive/gdata_wapi_service.h:62:
ConvertResourceEntryToFileResource(const google_apis::ResourceEntry& entry);
Pls add comments for this function.

How about moving this to drive_api_util?

[tzik, 2013-09-09 06:22:58]

Updated!

PTAL.

https://codereview.chromium.org/23437026/diff/3001/chrome/browser/drive/gdata...
File chrome/browser/drive/gdata_wapi_service.cc (right):

https://codereview.chromium.org/23437026/diff/3001/chrome/browser/drive/gdata...
chrome/browser/drive/gdata_wapi_service.cc:163:
file->set_shared_with_me_date(base::Time::Now());
On 2013/09/09 03:51:59, hidehiko wrote:
> Could you add comment, why this doesn't break the chrome and why it is
> impossible to assign the valid shared_with_me_date, here?

Done.

https://codereview.chromium.org/23437026/diff/3001/chrome/browser/drive/gdata...
chrome/browser/drive/gdata_wapi_service.cc:176: for
(ScopedVector<Link>::const_iterator itr = entry.links().begin();
On 2013/09/09 03:51:59, hidehiko wrote:
> IIUC, we use size_t i for iteration of vector in drive's code. Could you use
it
> for consistency?

Done.

https://codereview.chromium.org/23437026/diff/11001/chrome/browser/drive/gdat...
File chrome/browser/drive/gdata_wapi_service.h (right):

https://codereview.chromium.org/23437026/diff/11001/chrome/browser/drive/gdat...
chrome/browser/drive/gdata_wapi_service.h:62:
ConvertResourceEntryToFileResource(const google_apis::ResourceEntry& entry);
On 2013/09/09 03:52:00, hidehiko wrote:
> Pls add comments for this function.
> 
> How about moving this to drive_api_util?

Done.

[hidehiko, 2013-09-09 06:30:08]

lgtm

https://codereview.chromium.org/23437026/diff/21001/chrome/browser/drive/driv...
File chrome/browser/drive/drive_api_util.cc (right):

https://codereview.chromium.org/23437026/diff/21001/chrome/browser/drive/driv...
chrome/browser/drive/drive_api_util.cc:165: // FileResource
nit: you don't need this comment.

[tzik, 2013-09-09 06:50:59]

Thanks!

https://codereview.chromium.org/23437026/diff/21001/chrome/browser/drive/driv...
File chrome/browser/drive/drive_api_util.cc (right):

https://codereview.chromium.org/23437026/diff/21001/chrome/browser/drive/driv...
chrome/browser/drive/drive_api_util.cc:165: // FileResource
On 2013/09/09 06:30:08, hidehiko wrote:
> nit: you don't need this comment.

Done.

[commit-bot: I haz the power, 2013-09-09 06:51:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/23437026/21001

[commit-bot: I haz the power, 2013-09-09 06:51:23]

Failed to trigger a try job on chromium_presubmit
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-09-09 06:51:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/23437026/26001

[commit-bot: I haz the power, 2013-09-09 11:31:21]

Change committed as 222006