Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2849)

Unified Diff: base/async_socket_io_handler.h

Issue 23437011: Remove unnecessary public typedef from AsyncSocketIoHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/async_socket_io_handler.h
diff --git a/base/async_socket_io_handler.h b/base/async_socket_io_handler.h
index 200b1e3f557cff17ece0b993962f75d938d24783..2f4b13d74a1c4a851910b6f9a3216b6d59cf2152 100644
--- a/base/async_socket_io_handler.h
+++ b/base/async_socket_io_handler.h
@@ -11,13 +11,6 @@
namespace base {
-// The message loop callback interface is different based on platforms.
-#if defined(OS_WIN)
-typedef base::MessageLoopForIO::IOHandler MessageLoopIOHandler;
-#elif defined(OS_POSIX)
-typedef base::MessageLoopForIO::Watcher MessageLoopIOHandler;
-#endif
-
// Extends the CancelableSyncSocket class to allow reading from a socket
// asynchronously on a TYPE_IO message loop thread. This makes it easy to share
// a thread that uses a message loop (e.g. for IPC and other things) and not
@@ -53,7 +46,12 @@ typedef base::MessageLoopForIO::Watcher MessageLoopIOHandler;
//
class BASE_EXPORT AsyncSocketIoHandler
: public NON_EXPORTED_BASE(base::NonThreadSafe),
- public NON_EXPORTED_BASE(MessageLoopIOHandler) {
+// The message loop callback interface is different based on platforms.
+#if defined(OS_WIN)
+ public NON_EXPORTED_BASE(base::MessageLoopForIO::IOHandler) {
+#else
+ public NON_EXPORTED_BASE(base::MessageLoopForIO::Watcher) {
+#endif
public:
AsyncSocketIoHandler();
virtual ~AsyncSocketIoHandler();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698