Remove unnecessary public typedef from AsyncSocketIoHandler

Remove unnecessary public typedef from AsyncSocketIoHandler

TBR=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220077

[tommi (sloooow) - chröme, 2013-08-28 15:57:34]

Lgtm
On Aug 28, 2013 5:29 PM, <qsr@chromium.org> wrote:

> Reviewers: tommi,
>
> Description:
> Remove unnecessary public typedef from AsyncSocketIoHandler
>
> Please review this at
https://chromiumcodereview.**appspot.com/23437011/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M base/async_socket_io_handler.h
>
>
> Index: base/async_socket_io_handler.h
> diff --git a/base/async_socket_io_**handler.h b/base/async_socket_io_**
> handler.h
> index 200b1e3f557cff17ece0b993962f75**d938d24783..**
> 2f4b13d74a1c4a851910b6f9a3216b**6d59cf2152 100644
> --- a/base/async_socket_io_**handler.h
> +++ b/base/async_socket_io_**handler.h
> @@ -11,13 +11,6 @@
>
>  namespace base {
>
> -// The message loop callback interface is different based on platforms.
> -#if defined(OS_WIN)
> -typedef base::MessageLoopForIO::**IOHandler MessageLoopIOHandler;
> -#elif defined(OS_POSIX)
> -typedef base::MessageLoopForIO::**Watcher MessageLoopIOHandler;
> -#endif
> -
>  // Extends the CancelableSyncSocket class to allow reading from a socket
>  // asynchronously on a TYPE_IO message loop thread.  This makes it easy
> to share
>  // a thread that uses a message loop (e.g. for IPC and other things) and
> not
> @@ -53,7 +46,12 @@ typedef base::MessageLoopForIO::**Watcher
> MessageLoopIOHandler;
>  //
>  class BASE_EXPORT AsyncSocketIoHandler
>      : public NON_EXPORTED_BASE(base::**NonThreadSafe),
> -      public NON_EXPORTED_BASE(**MessageLoopIOHandler) {
> +// The message loop callback interface is different based on platforms.
> +#if defined(OS_WIN)
> +      public NON_EXPORTED_BASE(base::**MessageLoopForIO::IOHandler) {
> +#else
> +      public NON_EXPORTED_BASE(base::**MessageLoopForIO::Watcher) {
> +#endif
>   public:
>    AsyncSocketIoHandler();
>    virtual ~AsyncSocketIoHandler();
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[qsr, 2013-08-28 16:46:46]

+TBR darin for owner.

[commit-bot: I haz the power, 2013-08-28 17:02:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qsr@chromium.org/23437011/1

[commit-bot: I haz the power, 2013-08-28 20:13:37]

Change committed as 220077

[darin (slow to review), 2013-08-29 01:37:15]

LGTM

https://chromiumcodereview.appspot.com/23437011/diff/1/base/async_socket_io_h...
File base/async_socket_io_handler.h (right):

https://chromiumcodereview.appspot.com/23437011/diff/1/base/async_socket_io_h...
base/async_socket_io_handler.h:77: #if defined(OS_WIN)
Another approach would have been to create an inner class to hide the OS
specific details.  You could have used a PIMPL pattern.  This seems reasonable
given how most of the member variables are not shared between POSIX and WIN.